Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-15750] / [WFLY-13889] Remove the dependency on PicketBox from Weld. #14956

Merged
merged 12 commits into from Jan 17, 2022
Merged

[WFLY-15750] / [WFLY-13889] Remove the dependency on PicketBox from Weld. #14956

merged 12 commits into from Jan 17, 2022

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Nov 25, 2021

Raising as a draft as this is dependent on the following PR being approved first:
#14945

@darranl
[WFLY-15730] / [WFLY-15356] Remove the use of security-plugins from w…
2522a08 
…ebservices.
@darranl
[WFLY-15731] / [WFLY-15356] Remove use of security-plugins from the c…
e772c9e 
…onnector subsystem.
@darranl
[WFLY-15732] / [WFLY-15356] Remove use of security-plugins from Under…
e5e9b11 
…tow subsystem.
@darranl
[WFLY-15732] / [WFLY-15356] Remove the legacy mechanism SSO integration.
9f3f203
@darranl
[WFLY-15732] / [WFLY-15356] Temporarily ignore PolicyContextTestCase.
d1d6058
@darranl
[WFLY-15734] / [WFLY-15356] Remove security-plugins dependency from E…
7a97d57 
…JB3.
@darranl
[WFLY-15733] / [WFLY-15356] Remove security-plugins dependency from m…
144d802 
…essaging.
@darranl
[WFLY-15743] / [WFLY-15356] Remove security-plugins dependency from w…
7d5fdf1 
…eld.
@darranl
[WFLY-15743] / [WFLY-15356] Also remove the dependency from the trans…
6c41e20 
…formed subsystem.
@darranl
[WFLY-15356] Combine individual security-plugin removal changes.
fe07720
@darranl
[WFLY-15356] Remove the security-plugins module.
6535911
@darranl
Copy link
Contributor Author

darranl commented Nov 25, 2021

@manovotn / @ropalka Here is another one if either of you could please review the last commit:
40b430b

The other commits are a part of another PR but that last one removes the final dependency on PicketBox for Weld.

@github-actions github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label Nov 25, 2021
@github-actions
Copy link

Dependency Tree Analyzer Output:

Removed Dependencies:

  • org.wildfly:wildfly-security-plugins:jar:26.0.0.Beta1-SNAPSHOT:compile

CC @wildfly/prod

ropalka
ropalka reviewed Nov 25, 2021
View reviewed changes
Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit id 7500efa LGTM @darranl .

manovotn
manovotn reviewed Nov 26, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7500efa looks good.

@darranl darranl marked this pull request as ready for review January 17, 2022 10:48
@darranl darranl added the ready-for-merge Only for use by those with merge permissions! label Jan 17, 2022
@darranl darranl mentioned this pull request Jan 17, 2022
Closed
@darranl darranl merged commit 519decd into wildfly:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka left review comments

@manovotn manovotn manovotn left review comments

Assignees
No one assigned
Labels
deps-changed Dependencies have been checked, and there are changes highlighted in a comment ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
3 participants
@darranl @ropalka @manovotn