New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-15758] / [WFLY-13889] Remove the appclient dependency on PicketBox. #14959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnector subsystem.
…formed subsystem.
github-actions
bot
added
the
deps-changed
Dependencies have been checked, and there are changes highlighted in a comment
label
Nov 25, 2021
Dependency Tree Analyzer Output: Removed Dependencies:
CC @wildfly/prod |
@bstansberry would you be able to give the last commit a review on this one so we can merge? appclient itself by now should only use the dependency if legacy security is configured but that is now disabled. |
bstansberry
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting as a draft as this requires the following PR to be approved:
#14945
Only the last commit in this PR needs to be reviewed, the others are being reviewed elsewhere.