New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-15759] / [WFLY-13889] Remove the Undertow dependency on PicketBox. #14961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnector subsystem.
…formed subsystem.
Dependency Tree Analyzer Output: Removed Dependencies:
CC @wildfly/prod |
github-actions
bot
added
the
deps-changed
Dependencies have been checked, and there are changes highlighted in a comment
label
Nov 25, 2021
ropalka
approved these changes
Jan 10, 2022
@@ -85,7 +85,6 @@ | |||
<module name="org.jboss.vfs"/> | |||
<module name="org.jboss.as.version"/> | |||
<module name="org.jboss.logging"/> | |||
<module name="org.picketbox" optional="true"/> <!-- Needed to keep JACC working for now. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deps-changed
Dependencies have been checked, and there are changes highlighted in a comment
ready-for-merge
Only for use by those with merge permissions!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising as a draft as this depends on the following PR being approved:
#14945
https://issues.redhat.com/browse/WFLY-15759
Only the last commit of this PR needs to be reviewed.