Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-15759] / [WFLY-13889] Remove the Undertow dependency on PicketBox. #14961

Merged
merged 12 commits into from Jan 17, 2022

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Nov 25, 2021

Raising as a draft as this depends on the following PR being approved:
#14945

https://issues.redhat.com/browse/WFLY-15759

Only the last commit of this PR needs to be reviewed.

@github-actions
Copy link

Dependency Tree Analyzer Output:

Removed Dependencies:

  • org.wildfly:wildfly-security-plugins:jar:26.0.0.Beta1-SNAPSHOT:compile

CC @wildfly/prod

@github-actions github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label Nov 25, 2021
@@ -85,7 +85,6 @@
<module name="org.jboss.vfs"/>
<module name="org.jboss.as.version"/>
<module name="org.jboss.logging"/>
<module name="org.picketbox" optional="true"/> <!-- Needed to keep JACC working for now. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darranl darranl marked this pull request as ready for review January 17, 2022 10:52
@darranl darranl added the ready-for-merge Only for use by those with merge permissions! label Jan 17, 2022
@darranl darranl mentioned this pull request Jan 17, 2022
@darranl darranl merged commit 6a66820 into wildfly:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-changed Dependencies have been checked, and there are changes highlighted in a comment ready-for-merge Only for use by those with merge permissions!
Projects
None yet
2 participants