WFLY-15897 Messaging BroadcastGroupDefinition & DiscoveryGroupDefinition fixes #15080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ehsavoie , would you review please? This is fix for issues uncovered when trying to add and edit broadcast groups and discovery groups in web console. |
github-actions
bot
added
the
deps-ok
|
Hi @TomasHofman -- thanks for this. Please update the commit message and PR title to reference WFLY-15897 instead of the JBEAP. Thanks. |
TomasHofman
changed the title
TomasHofman
force-pushed
the
JBEAP-23054
branch
from
ea103f6
to
edd549b
Compare
|
Sorry, issue code fixed :). |
|
@TomasHofman could your PR comments go into the commit message also ? |
…ion fixes * Change BroadcastGroupDefinition#CONNECTOR_REFS to be required, as both JGroupsBroadcastGroupDefinition#CONNECTOR_REFS and SocketBroadcastGroupDefinition#CONNECTOR_REFS are required. This is causing the web console not to include the connectors attribute in the Add form. * BroadcastGroupWriteAttributeHandler#SOCKET_INSTANCE references wrong attributes list. Causes NPE when editing resources. * Avoid NPE in SocketBroadcastGroupAdd and JGroupsBroadcastGroupAdd when the provided socket binding doesn't have broadcast address defined. Print helpful message instead. * Make TranslatedWriteAttributeHandler not to write into attribute, if the attribute is in the list of ignored attributes for given resource (causes NPE).
TomasHofman
force-pushed
the
JBEAP-23054
branch
from
edd549b
to
635a232
Compare
|
@ehsavoie sure, done. |
ehsavoie
approved these changes
Jan 13, 2022
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-15897
https://issues.redhat.com/browse/JBEAP-23054 (EAP 8)
BroadcastGroupDefinition#CONNECTOR_REFSto be required, as bothJGroupsBroadcastGroupDefinition#CONNECTOR_REFSandSocketBroadcastGroupDefinition#CONNECTOR_REFSare required. This is causing the web console not to include the connectors attribute in the Add form.BroadcastGroupWriteAttributeHandler#SOCKET_INSTANCEreferences wrong attributes list. Causes NPE when editing resources.SocketBroadcastGroupAddandJGroupsBroadcastGroupAddwhen the provided socket binding doesn't have broadcast address defined. Print helpful message instead.TranslatedWriteAttributeHandlernot to write into attribute, if the attribute is in the list of ignored attributes for given resource (causes NPE).