Jakarta JSON Upgrades for Jakarta EE 10 #15423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d migrate to using the new Eclipse Parsson implementation. https://issues.redhat.com/browse/WFLY-16263 https://issues.redhat.com/browse/WFLY-16264 Signed-off-by: James R. Perkins <jperkins@redhat.com>
…asson to 3.0.0-RC1. https://issues.redhat.com/browse/WFLY-16200 https://issues.redhat.com/browse/WFLY-16262 Signed-off-by: James R. Perkins <jperkins@redhat.com>
github-actions
bot
added
the
deps-ok
bstansberry
reviewed
Apr 13, 2022
| --> | ||
| <!-- TODO Consider dropping direct dep on core-galleon-pack and instead using | ||
| a source dep, eliminating the need to re-provision this just to get a | ||
| different version. --> |
There was a problem hiding this comment.
I don't think this is relevant to this file. IIRC I wrote it somewhere. I doubt it's relevant there any more either. ;)
There was a problem hiding this comment.
Yeah. I almost removed it too. Then though what if it means something to core :) I can remove it though.
There was a problem hiding this comment.
Well. I'm wrong. It's relevant to this file (assuming you'll add this module in core) but I guess isn't relevant to the org.glassfish.jakarta.json one.
If this module.xml file and the alias one are going into core with the same content, I believe both of these can be removed once the core upgrade with them in it is integrated. The TODO I was talking about is done.
bstansberry
approved these changes
Apr 13, 2022
|
Thanks @jamezp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Jakarta JSON Processing to 2.1.0 and migrate to using Eclipse Parsson. Also upgrade Jakarta JSON Binding to 3.0.0 and Yasson to 3.0.0-RC1.