Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-15443] Migrate MicroProfile JWT to Jakarta EE 9 Native Components. #15457

Merged
merged 6 commits into from Apr 25, 2022

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Apr 21, 2022

https://issues.redhat.com/browse/WFLY-15443

It is not great that we have an Elytron version override for one module in the parent pom of WildFly but this should be short lived once we can drop Jakarta EE 8 from main.

@darranl darranl added the EE9 label Apr 21, 2022
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 21, 2022
@bstansberry
Copy link
Contributor

@darranl WFP test fails with:

2022-04-21 20:41:12,453 ERROR [org.jboss.as.controller.management-operation] (ServerService Thread Pool -- 67) WFLYCTL0013: Operation ("add") failed - address: ([("subsystem" => "microprofile-jwt-smallrye")]): java.lang.ExceptionInInitializerError
	at org.wildfly.extension.microprofile.jwt-smallrye@27.0.0.Beta1-SNAPSHOT//org.wildfly.extension.microprofile.jwt.smallrye.MicroProfileJWTSubsystemAdd.performBoottime(MicroProfileJWTSubsystemAdd.java:42)
	at org.jboss.as.controller@19.0.0.Beta7//org.jboss.as.controller.AbstractBoottimeAddStepHandler.performBoottime(AbstractBoottimeAddStepHandler.java:144)
	at org.jboss.as.controller@19.0.0.Beta7//org.jboss.as.controller.AbstractBoottimeAddStepHandler.performRuntime(AbstractBoottimeAddStepHandler.java:119)
	at org.jboss.as.controller@19.0.0.Beta7//org.jboss.as.controller.AbstractAddStepHandler$1.execute(AbstractAddStepHandler.java:164)
	at org.jboss.as.controller@19.0.0.Beta7//org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:1045)
	at org.jboss.as.controller@19.0.0.Beta7//org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:777)
	at org.jboss.as.controller@19.0.0.Beta7//org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:466)
	at org.jboss.as.controller@19.0.0.Beta7//org.jboss.as.controller.ParallelBootOperationStepHandler$ParallelBootTask.run(ParallelBootOperationStepHandler.java:384)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
	at java.base/java.lang.Thread.run(Thread.java:833)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.JBossThread.run(JBossThread.java:513)
Caused by: java.lang.IllegalArgumentException: Invalid logger interface org.wildfly.extension.microprofile.jwt.smallrye._private.MicroProfileJWTLogger (implementation not found in ModuleClassLoader for Module "org.wildfly.extension.microprofile.jwt-smallrye" version 27.0.0.Beta1-SNAPSHOT from local module loader @73302995 (finder: local module finder @1838ccb8 (roots: /opt/buildAgent/work/dc9a11b6a14b0d86/ee-9/dist/target/wildfly-preview-27.0.0.Beta1-SNAPSHOT/modules,/opt/buildAgent/work/dc9a11b6a14b0d86/ee-9/dist/target/wildfly-preview-27.0.0.Beta1-SNAPSHOT/modules/system/layers/base,/opt/buildAgent/work/dc9a11b6a14b0d86/testsuite/integration/web/target/modules)))
	at org.jboss.logging@3.4.3.Final//org.jboss.logging.Logger.doGetMessageLogger(Logger.java:2564)
	at org.jboss.logging@3.4.3.Final//org.jboss.logging.Logger.getMessageLogger(Logger.java:2530)
	at org.jboss.logging@3.4.3.Final//org.jboss.logging.Logger.getMessageLogger(Logger.java:2516)
	at org.wildfly.extension.microprofile.jwt-smallrye@27.0.0.Beta1-SNAPSHOT//org.wildfly.extension.microprofile.jwt.smallrye._private.MicroProfileJWTLogger.<clinit>(MicroProfileJWTLogger.java:40)
	... 14 more

@darranl
Copy link
Contributor Author

darranl commented Apr 22, 2022

Looks like I was missing a logging processor dependency - the build is getting further now.

@@ -544,6 +544,9 @@
<exclude>org.wildfly:wildfly-clustering-infinispan-extension\z</exclude>
<exclude>org.wildfly:wildfly-clustering-web-infinispan\z</exclude>

<!-- Contains module names which have been aliased, additional transformation not required. -->
<exclude>org.wildfly:wildfly-microprofile-jwt-smallrye\z</exclude>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this module be excluded from the maven scope instead of excluding the transformation?

I mean, exclude it here:

<artifactId>wildfly-mp-feature-pack-galleon-common</artifactId>
, because wildfly-microprofile-jwt-smallrye-jakarta is its replacement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Thanks @yersan .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yersan I will add that exclude and remove this one.

@bstansberry bstansberry merged commit 16bb933 into wildfly:main Apr 25, 2022
@bstansberry
Copy link
Contributor

Thanks @darranl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
5 participants