New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-15443] Migrate MicroProfile JWT to Jakarta EE 9 Native Components. #15457
Conversation
@darranl WFP test fails with:
|
Looks like I was missing a logging processor dependency - the build is getting further now. |
ee-9/feature-pack/pom.xml
Outdated
@@ -544,6 +544,9 @@ | |||
<exclude>org.wildfly:wildfly-clustering-infinispan-extension\z</exclude> | |||
<exclude>org.wildfly:wildfly-clustering-web-infinispan\z</exclude> | |||
|
|||
<!-- Contains module names which have been aliased, additional transformation not required. --> | |||
<exclude>org.wildfly:wildfly-microprofile-jwt-smallrye\z</exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not this module be excluded from the maven scope instead of excluding the transformation?
I mean, exclude it here:
wildfly/ee-9/feature-pack/pom.xml
Line 668 in 8fc816d
<artifactId>wildfly-mp-feature-pack-galleon-common</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Thanks @yersan .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yersan I will add that exclude and remove this one.
…g the transformation.
Thanks @darranl |
https://issues.redhat.com/browse/WFLY-15443
It is not great that we have an Elytron version override for one module in the parent pom of WildFly but this should be short lived once we can drop Jakarta EE 8 from main.