Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-16327] Upgrade Apache Avro to 1.10.2 #15500

Closed
wants to merge 1 commit into from
Closed

[WFLY-16327] Upgrade Apache Avro to 1.10.2 #15500

wants to merge 1 commit into from

Conversation

boris-unckel
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 29, 2022
@boris-unckel boris-unckel mentioned this pull request Apr 29, 2022
Merged
@boris-unckel
Copy link
Contributor Author

@scottmarlow All links are in the Jira, including the alignment with upstream Hibernate. Could you review and approve, please?

@bstansberry
Copy link
Contributor

/retest

@jamezp jamezp added the ready-for-merge Only for use by those with merge permissions! label May 13, 2022
@bstansberry
Copy link
Contributor

bstansberry commented May 13, 2022 •
edited

@yrodiere Following the merge of #15185, std WildFly is on 1.11.0 in main. We could move the 1.11.0 version property to ee-9/pom.xml to have it only take effect in WFP, and then make this change in std WF. Simply adding <version.org.apache.avro>1.11.0</version.org.apache.avro> is enough to get WFP using 1.11.0. Or, if 1.11.0 is fine with the current std WF we could just close this PR as out of date.

Either way #15501 is ok as main being 1.11.0 meets the upstream first requirement for moving 26.x to 1.10.2.

We'll be converting std WF to use the WFP dependency set sometime in the next month.

@jamezp jamezp added rebase-this PR has a merge conflict. and removed ready-for-merge Only for use by those with merge permissions! labels May 13, 2022
@yrodiere
Copy link
Contributor

Simply adding <version.org.apache.avro>1.11.0</version.org.apache.avro> is enough to get WFP using 1.11.0.

Note that I also had to make some changes to the Maven exclusions and the JBoss module itself in order to upgrade to Avro 1.11, so changing the version is not just about updating the Maven property: 9676527 . The changes might also work with Avro 1.10, though; I don't know.

Or, if 1.11.0 is fine with the current std WF we could just close this PR as out of date.

I don't know if it's fine; I didn't test that in Hibernate Search upstream, and it seems we don't have any tests involving Hibernate Search 5 + Avro in WildFly.

However, closing this PR would still be my preference.

I think the intent is to move to Hibernate ORM 6 + Search 6 in the next release of WF based off the main branch, right? If so, the problem (if any) will disappear as we remove Hibernate Search 5 from WildFly.

Either way #15501 is ok as main being 1.11.0 meets the upstream first requirement for moving 26.x to 1.10.2.

Right, @boris-unckel 's work was necessary whatever we do with this PR: we needed the upgrade to Avro 1.10 in the 26.x branch.

@boris-unckel
Copy link
Contributor Author

@ALL Thanks for your feedback. It's not useful to downgrade main. The PR is withdrawn.

@boris-unckel boris-unckel deleted the WFLY-16327_upgrade_avro branch May 16, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmarlow scottmarlow scottmarlow approved these changes

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes rebase-this PR has a merge conflict.
Projects
None yet
Milestone
No milestone
5 participants
@boris-unckel @bstansberry @yrodiere @scottmarlow @jamezp