[WFLY-16334] Upgrade Apache Thrift 0.16.0 #15508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
|
@jasondlee FYI in the past we have been cautious about upgrading thrift, as we want to align with what was used in jaegertracing. I have no idea about the current alignment. |
|
@bstansberry @jasondlee The changelog of thrift is not very readable, I agree. A local test run was fine, but for dynamic use in tracing that must not be a good test coverage to have integration only. |
|
It's the current 0.14.1 version https://mvnrepository.com/artifact/io.jaegertracing/jaeger-thrift/1.6.0 |
|
PR withdrawn: The aligned version of io.jaegertracing:jaeger-thrift is needed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/WFLY-16334