Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-16449] Upgrade ASM to 9.3 #15612

Merged
merged 1 commit into from Jun 10, 2022
Merged

[WFLY-16449] Upgrade ASM to 9.3 #15612

merged 1 commit into from Jun 10, 2022

Conversation

ropalka
Copy link
Contributor

@ropalka ropalka commented Jun 5, 2022

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jun 5, 2022
@scottmarlow
Copy link
Contributor

scottmarlow commented Jun 6, 2022 •
edited

asm.asm module dependencies from searching in EE-9/dist/target:

io/smallrye/config/main/module.xml
org/jboss/as/webservices/server/integration/main/module.xml
org/apache/cxf/ws-security/main/module.xml
org/apache/cxf/main/module.xml
org/apache/cxf/services-sts/main/module.xml
org/apache/cxf/impl/main/module.xml

@jimma is the ASM upgrade to 9.3 compatible with the above cxf/webservices modules?

@ropalka ropalka requested review from jimma and kabir June 7, 2022 06:25
@jimma
Copy link
Contributor

jimma commented Jun 7, 2022

@scottmarlow Upgrade to ASM 9.3 is good for webservice. Thanks.

@ropalka
Copy link
Contributor Author

ropalka commented Jun 10, 2022

Is ASM upgrade fine from Smallrye PoV @kabir ?

@kabir
Copy link
Contributor

kabir commented Jun 10, 2022

@ropalka It should be. I didn't even know SR config used it until now :-) But I see their main branch has updated to 9.3 and no change was made to the code using asm when the update happened

@bstansberry bstansberry added the ready-for-merge Only for use by those with merge permissions! label Jun 10, 2022
@bstansberry bstansberry merged commit be6c3c4 into wildfly:main Jun 10, 2022
@bstansberry
Copy link
Contributor

Thanks @ropalka

@ropalka ropalka deleted the WFLY-16449 branch June 11, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimma jimma jimma approved these changes

@bstansberry bstansberry bstansberry approved these changes

@scottmarlow scottmarlow scottmarlow approved these changes

@kabir kabir Awaiting requested review from kabir

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
5 participants
@ropalka @scottmarlow @jimma @kabir @bstansberry