[WFLY-16190] FilesystemRealmEncryptedTestCase fails when run from a bootable jar #15699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
reviewed
Jun 24, 2022
| @@ -0,0 +1,150 @@ | |||
| /* | |||
| * JBoss, Home of Professional Open Source. | |||
| * Copyright 2020, Red Hat Middleware LLC, and individual contributors | |||
| import org.junit.runner.RunWith; | ||
|
|
||
| /** | ||
| * Full authentication tests for Elytron Encrypted Filesystem Realm. |
There was a problem hiding this comment.
Since this is testing the wrong secret key case specifically, it would be good to update the description here.
| @RunWith(Arquillian.class) | ||
| @RunAsClient | ||
| @ServerSetup({FilesystemRealmEncryptedSecretKeyTestCase.SetUpTask.class}) | ||
| public class FilesystemRealmEncryptedSecretKeyTestCase { |
There was a problem hiding this comment.
Would also be good to update the class name to something like FilesystemRealmEncryptedWrongSecretKeyTestCase.
Ashpan
force-pushed
the
WFLY-16190
branch
2 times, most recently
from
ce0db63
to
1c0f02a
Compare
github-actions
bot
added
the
deps-ok
Ashpan
force-pushed
the
WFLY-16190
branch
2 times, most recently
from
a22a0e5
to
97ff84c
Compare
bstansberry
changed the title
|
@Ashpan This isn't required for this to be merged, but if you need to update this branch for some other reason please correct the commit message to remove the duplicate text. |
|
@bstansberry I don't see any duplicated text on the commit message, I only saw it on the title of this PR, which you already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-16190