Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-16428] LegacyCompliantPrincipalPropagationTestCase fails in Windows #15705

Merged
merged 1 commit into from Jun 30, 2022
Merged

[WFLY-16428] LegacyCompliantPrincipalPropagationTestCase fails in Windows #15705

merged 1 commit into from Jun 30, 2022

Conversation

cam-rod
Copy link
Contributor

@cam-rod cam-rod commented Jun 27, 2022

@wildfly-ci
Copy link

Hello, cam-rod. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jun 27, 2022
fjuma
fjuma requested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cam-rod! I've just added a small comment.

It would also be good to update the WFLY issue description to explain why this fix was needed just to provide some context there.

.../jboss/as/test/manualmode/weld/builtinBeans/LegacyCompliantPrincipalPropagationTestCase.java Outdated
ModelNode modelNode = createAddOperation(PathAddress.parseCLIStyleAddress(("/subsystem=ejb3/application-security-domain=other")).toModelNode());
modelNode.get("security-domain").set("ApplicationDomain");
managementClient.getControllerClient().execute(modelNode);

ServerReload.reloadIfRequired(managementClient);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reload can be removed too since we're no longer adding the application-security-domain resource.

@fjuma
Copy link
Contributor

fjuma commented Jun 27, 2022

/ok-to-test

@Skyllarr
Copy link
Contributor

@cam-rod Thank you, LGTM

@darranl darranl added the ready-for-merge Only for use by those with merge permissions! label Jun 30, 2022
@darranl darranl merged commit db4cf77 into wildfly:main Jun 30, 2022
@cam-rod cam-rod deleted the WFLY-16428 branch June 30, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjuma fjuma fjuma requested changes

@darranl darranl darranl approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
5 participants
@cam-rod @wildfly-ci @fjuma @Skyllarr @darranl