Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-16554] Increase JVM heap max-size to 100m for JVMServerPropertiesTestCase #15715

Merged
merged 1 commit into from Jul 20, 2022

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Jun 29, 2022

Issue: https://issues.redhat.com/browse/WFLY-16554

Thanks for submitting your Pull Request!

Please delete this text, and add a link to the Jira issue solved by this PR.

If this PR is not for the 'main' branch you must add a link to the equivalent change in 'main'.

Remember to use the Jira issue ID in the PR title and any commits.

@gaol
Copy link
Contributor Author

gaol commented Jun 29, 2022

@yersan would you please review? thanks

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jun 29, 2022
@gaol
Copy link
Contributor Author

gaol commented Jun 29, 2022

@yersan please on hold, I think we may also increase jvm heap max-size in domain-standard.xml which is used in CloneProfileTestCase, I can see OOME of CLITestSuite in my container based CI. I think it may relate to this.

@yersan yersan self-requested a review June 29, 2022 15:12
@gaol
Copy link
Contributor Author

gaol commented Jun 30, 2022

@yersan this is ready for review, thanks :)

Copy link
Contributor

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaol , LGTM, I would suggest squashing both commits or at least add the Jira number to the second one

…esTestCase

Increase max-size of jvm heap to 100m in domain-standard.xml and domain-standard-ee.xml
@gaol
Copy link
Contributor Author

gaol commented Jun 30, 2022

Thanks @yersan , done of squashing the commits :)

@darranl
Copy link
Contributor

darranl commented Jul 1, 2022

I have just triggered the three failed jobs, they don't look related.

@bstansberry bstansberry merged commit 55851cb into wildfly:main Jul 20, 2022
@bstansberry
Copy link
Contributor

Thanks @gaol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
4 participants