Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26.x][WFLY-16829] Upgrade Apache cxf to 3.4.8 #15945

Closed

Conversation

boris-unckel
Copy link
Contributor

@bstansberry bstansberry added the 26.x WildFly 26 label Aug 17, 2022
@boris-unckel
Copy link
Contributor Author

Please find all links to release notes, git tags, github-diff in the Jira.

This was referenced Aug 22, 2022
@jimma
Copy link
Contributor

jimma commented Aug 23, 2022

@boris-unckel Thanks for the PR, again! I'll look at the tck result before this upgrade. Can you please give me some time to have a tck check locally for this version ?

@jimma jimma added the hold PR should not be merged for some reason. label Aug 23, 2022
@boris-unckel
Copy link
Contributor Author

@jimma It seems there is a deadline for WF26x: #15962 (comment)

@bstansberry
Copy link
Contributor

It is unlikely we'd include this one in 26.1.2. A CXF upgrade is a pretty large thing to do at the last minute and the change log doesn't show anything particularly critical.

@boris-unckel
Copy link
Contributor Author

@bstansberry I don't consider this one critical CXF-7996 Jakarta EE TCKs and compatibility but there is a long list of fixes behind. They have been solved incremental (previous versions contain fixes, too) and the work has been finalized in this minor.

@jimma
Copy link
Contributor

jimma commented Aug 24, 2022

Except these two changes, there are all related to jaxrs change , component upgrade and test fix.

@bstansberry
Copy link
Contributor

  • @boris-unckel I've gone through all the commits in CXF 3.4.8. These two commits are we need to have a fully tck test , especially the first one :
  • apache/cxf@bb4d26f

This caused a regression, to be fixed in 3.4.9:

https://issues.apache.org/jira/browse/CXF-8733

This is an Improvement, not a bug fix.

https://issues.apache.org/jira/browse/CXF-8699

Except these two changes, there are all related to jaxrs change , component upgrade and test fix.

@boris-unckel
Copy link
Contributor Author

@jimma @bstansberry Thanks for time investigating this. It seems this has not enough benefit for the release. Even downstream I would wait for 3.4.9.

@boris-unckel boris-unckel deleted the WFLY-16829_upgrade_apache_cxf branch August 25, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.x WildFly 26 hold PR should not be merged for some reason.
Projects
None yet
3 participants