Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-16956] Move jboss-ejb-client-legacy to the standard-ee bom as s… #16037

Merged
merged 1 commit into from Sep 23, 2022

Conversation

bstansberry
Copy link
Contributor

…ome deliverables associated with WildFly include it

https://issues.redhat.com/browse/WFLY-16956

…ome deliverables associated with WildFly include it
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Sep 8, 2022
@jbliznak
Copy link
Contributor

Is anything blocking this one from being merged?

@bstansberry
Copy link
Contributor Author

@jbliznak It needs someone to approve it. You're welcome to do that. :)

Copy link
Contributor

@jbliznak jbliznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I thought you don't need one :)

this is the difference in particular BOM after the change jbliznak/test-boms@aa52228...bfcd431

it is a bit more than expected and order of dependencies can matter but it still looks ok to me, non-legacy BOM (https://repo1.maven.org/maven2/org/wildfly/wildfly-ejb-client-bom/27.0.0.Alpha4/wildfly-ejb-client-bom-27.0.0.Alpha4.pom) also has those jakarta APIs in there before actual client dependency so at least they are now more similar.

@bstansberry bstansberry merged commit 9092c35 into wildfly:main Sep 23, 2022
@bstansberry bstansberry deleted the WFLY-16956 branch September 23, 2022 21:45
@bstansberry
Copy link
Contributor Author

Thanks for the review / test of the result @jbliznak!

The folks who have permissions to merge things try to resist the temptation to merge our own stuff if it hasn't gotten a review. I think we're mostly successful. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
2 participants