Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-16766] Migrate the service used on the Extending WildFly documentation to the new MSC API #16171

Merged
merged 2 commits into from Oct 13, 2022
Merged

[WFLY-16766] Migrate the service used on the Extending WildFly documentation to the new MSC API #16171

merged 2 commits into from Oct 13, 2022

Conversation

anilabhabaral
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Oct 13, 2022
bstansberry
bstansberry requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anilabhabaral

The class declaration on L573 should be changed as well as org.jboss.msc.Service is not generic.

s/Service/Service/g

@anilabhabaral
Copy link
Contributor Author

Sure @bstansberry I will make the changes.

@anilabhabaral
Copy link
Contributor Author

Hello @bstansberry i made the suggested changes. Could you please check ?

@bstansberry bstansberry merged commit e8ce80c into wildfly:main Oct 13, 2022
@bstansberry
Copy link
Contributor

Thanks @anilabhabaral

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
2 participants
@anilabhabaral @bstansberry