Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-17206] Fix NetworkHealthTestCase failures on Windows with IPv4 #16219

Merged
merged 1 commit into from Oct 28, 2022
Merged

[WFLY-17206] Fix NetworkHealthTestCase failures on Windows with IPv4 #16219

merged 1 commit into from Oct 28, 2022

Conversation

bstansberry
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Oct 28, 2022
ehsavoie
ehsavoie reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@ehsavoie ehsavoie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we take advantage of this to remove the line test (if(TestSuiteEnvironment.isWindows()) { )

@bstansberry
Copy link
Contributor Author

@ehsavoie

Shouldn't we take advantage of this to remove the line test (if(TestSuiteEnvironment.isWindows()) { )

On Linux I wanted to test the default values in the AttributeDefinitions, as they are meant to work on Linux and that's what the typical end user would use. So I limited it to just Windows, where we know the AD defaults don't work.

@bstansberry bstansberry merged commit a039afe into wildfly:main Oct 28, 2022
@bstansberry bstansberry deleted the WFLY-17206 branch October 28, 2022 15:06
@bstansberry
Copy link
Contributor Author

@ehsavoie Before merging I updated the comment to explain more clearly my thinking on that. We can certainly change it though if the default AD values are properly tested in other ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsavoie ehsavoie ehsavoie approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
2 participants
@bstansberry @ehsavoie