WFLY-8718: remove xa-datasource-class from JDBC driver definition #16271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
michpetrov
force-pushed
the
wfly-8718
branch
from
f1fe0aa
to
71223c1
Compare
michpetrov
force-pushed
the
wfly-8718
branch
from
71223c1
to
e5cd22b
Compare
|
@tadamski Can you please review, it looks like this parameter was just never used? |
tadamski
suggested changes
Apr 5, 2023
There was a problem hiding this comment.
@michpetrov could you please also deprecate the related attribute so that we can remove it ultimately?
|
@tadamski which one do you want to deprecate? The one I removed is still used in XaDataSourceDefinition where I assume it is necessary, it was just wrongly included in the driver definition. |
|
@michpetrov true, my mistake, approving |
tadamski
approved these changes
Apr 8, 2023
darranl
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: WFLY-8718
The attribute definition itself was kept in since it used in xa-datasource but it shouldn't be included in the definition of a driver (which already has DRIVER_XA_DATASOURCE_CLASS_NAME). This has no impact on schema definition.