[WFLY-15405] AMQP Connector for reactive messaging #16281

kabir · 2022-11-14T15:43:27Z

https://issues.redhat.com/browse/WFLY-15405 - Support for the AMQP connector in the MP Reactive Messaging subsystem

Includes #17343 so this can be tested with the latest SmallRye Reactive Messaging which will likely be merged by the time this is tested

bstansberry · 2022-11-14T22:53:44Z

@kabir The weld/transaction commit can be rebased out; that JIRA is resolved in main.

kabir · 2022-11-15T09:38:03Z

@bstansberry oops. Should be good now

github-actions · 2022-11-15T09:47:19Z

Dependency Tree Analyzer Output:

New Dependencies:

io.smallrye.reactive:smallrye-mutiny-vertx-amqp-client:jar:3.6.0:compile
io.smallrye.reactive:smallrye-reactive-messaging-amqp:jar:4.11.0:compile
io.vertx:vertx-amqp-client:jar:4.4.6:compile
io.vertx:vertx-proton:jar:4.4.6:compile
org.wildfly:wildfly-microprofile-reactive-messaging-amqp:jar:31.0.0.Beta1-SNAPSHOT:compile

CC @wildfly/prod

jstourac

I've went through circa half of this PR and put some comments. Mostly regarding the documentation. I'll do rest later :)

...asciidoc/_admin-guide/subsystem-configuration/MicroProfile_Reactive_Messsaging_SmallRye.adoc

...mon/src/main/resources/layers/standalone/microprofile-reactive-messaging-amqp/layer-spec.xml

...galleon-common/src/main/resources/modules/system/layers/base/io/vertx/proton/main/module.xml

...file/reactive/messaging/config/amqp/ssl/context/AmqpReactiveMessagingSslConfigProcessor.java

...tive/messaging/config/amqp/ssl/context/_private/MicroProfileReactiveMessagingAmqpLogger.java

...microprofile/reactive/messaging/common/security/BaseReactiveMessagingSslConfigProcessor.java

...tension/microprofile/reactive/messaging/deployment/ReactiveMessagingDependencyProcessor.java

microprofile/reactive-messaging-smallrye/kafka/pom.xml

...le/reactive/messaging/config/kafka/ssl/context/KafkaReactiveMessagingSslConfigProcessor.java

...asciidoc/_admin-guide/subsystem-configuration/MicroProfile_Reactive_Messsaging_SmallRye.adoc

...file/reactive/messaging/config/amqp/ssl/context/AmqpReactiveMessagingSslConfigProcessor.java

jstourac

Hi Kabir, I've put two more minor comments regarding the documentation. I believe that this is all from me at the moment. Note there is one comment from me from last week that you didn't address. Is it on purpose or you just missed it/postponed it? 🙂

jstourac · 2023-05-23T11:58:47Z

...asciidoc/_admin-guide/subsystem-configuration/MicroProfile_Reactive_Messsaging_SmallRye.adoc

+
+`mp.messaging.outgoing.to.connector=smallrye-amqp` says that we want to use AMQP to back the `to` channel. Note that the value `smallrye-amqp` is SmallRye Reactive Messaging specific, and will only be understood if the AMQP connector is enabled.
+
+`mp.messaging.outgoing.to.address=my-queue` says that we will send data via `to` channel to the AMQP queue on address called `my-queue`.


Suggested change

`mp.messaging.outgoing.to.address=my-queue` says that we will send data via `to` channel to the AMQP queue on address called `my-queue`.

`mp.messaging.outgoing.to.address=my-topic` says that we will send data via `to` channel to the AMQP topic (or queue) on address called `my-topic`.

Just to stay consistent with the above example.

jstourac · 2023-05-23T11:59:40Z

...asciidoc/_admin-guide/subsystem-configuration/MicroProfile_Reactive_Messsaging_SmallRye.adoc

+
+`mp.messaging.incoming.from.connector=smallrye-amqp` says that we want to use AMQP to back the `from` channel. As above, the value `smallrye-amqp` is SmallRye Reactive Messaging specific.
+
+`mp.messaging.incoming.from.address=my-queue` says says that the channel named `from` will read data from the AMQP topic (or queue) on address called `my-topic`.


Suggested change

`mp.messaging.incoming.from.address=my-queue` says says that the channel named `from` will read data from the AMQP topic (or queue) on address called `my-topic`.

`mp.messaging.incoming.from.address=my-topic` says that the channel named `from` will read data from the AMQP topic (or queue) on address called `my-topic`.

kabir · 2023-05-23T12:57:50Z

@jstourac I missed it. Hopefully it should be fine now :-)

mnovak1 · 2023-12-12T09:29:00Z

FYI: I've run Wildfly TS with latest changes and there is no issue related to this PR.

Google DNS causes problems looking up services in Kubernetes

darranl · 2023-12-14T15:37:08Z

...ration/microprofile/reactive/messaging/amqp/SslAmqpWithSslConfiguredOnConnectorTestCase.java

+/*
+ * Copyright The WildFly Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */


This one has two headers.

Removed the second one

darranl · 2023-12-14T16:06:42Z

...croprofile/reactive/messaging/common/_private/MicroProfileReactiveMessagingCommonLogger.java

@@ -0,0 +1,57 @@
+/*
+ * JBoss, Home of Professional Open Source.


This should be ASL now?

See L24-27 -- it looks like the header switch got messed up.

@bstansberry already fixed?

darranl · 2023-12-14T16:07:00Z

...le/reactive/messaging/config/kafka/ssl/context/KafkaReactiveMessagingSslConfigProcessor.java

@@ -0,0 +1,74 @@
+/*
+ * JBoss, Home of Professional Open Source.


This should be ASL now?

bstansberry · 2023-12-14T19:51:56Z

...asciidoc/_admin-guide/subsystem-configuration/MicroProfile_Reactive_Messsaging_SmallRye.adoc

+Next we will briefly discuss each of these entries. Remember the `to` channel is on the `send()` method, and the `from` channel is on the `receive()` method.
+
+
+'amqp-host=localhost' '`amqp-port=5672` points the connector to an AMQP broker running on `localhost:5672`. As before we could also have done these for an individual channel by for example specifying  `mp.messaging.outgoing.to.host=localhost` instead. If the host is not specified, it defaults to `localhost.


@kabir This can be done in a follow up fix, but whatever turns on italics here needs to be fixed.

Note -- please don't make any docs fixes I mention here on this PR unless you have to change something that justifies new CI. They can come later.

@bstansberry I've never seen the source be italic before, but it turns out it was due to some unclosed quotes

Done in #17491

bstansberry · 2023-12-14T19:54:08Z

galleon-pack/galleon-shared/pom.xml

+        <dependency>
+            <groupId>io.smallrye.reactive</groupId>
+            <artifactId>smallrye-mutiny-vertx-amqp-client</artifactId>
+            <exclusions>


Future fix:

'exclusions' should not appear here unless there is a good reason they don't appear in the bom.

AFAICR those boms did not exist when I worked on this code 1.5 years ago :-D

I'll leave it as-is, and have opened https://issues.redhat.com/browse/WFLY-18852 to clean up this pom since I see other exclusions than mine

Made a start in #17491

bstansberry · 2023-12-14T20:00:42Z

testsuite/layers-expansion/pom.xml

@@ -705,6 +705,7 @@
                                                <layer>microprofile-openapi</layer>
                                                <layer>microprofile-reactive-streams-operators</layer>
                                                <layer>microprofile-reactive-messaging</layer>
+                                                <layer>microprofile-reactive-messaging-amqp</layer>


Please file a JIRA to add a provisioning execution with only the layer. All layers need an individual execution.

Fixed in #17491

bstansberry · 2023-12-15T22:07:22Z

Thanks @kabir!

kabir added Feature PR provides a new feature missing-reqs Features missing one or more of the pre-merge requirements labels Nov 14, 2022

kabir force-pushed the reactive-amqp-15405 branch from 7258098 to 777dd34 Compare November 14, 2022 15:49

kabir force-pushed the reactive-amqp-15405 branch from 777dd34 to 133380c Compare November 15, 2022 09:37

github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label Nov 15, 2022

kabir force-pushed the reactive-amqp-15405 branch from 133380c to b8342b3 Compare November 29, 2022 20:22

kabir force-pushed the reactive-amqp-15405 branch from b8342b3 to 67d8c99 Compare January 10, 2023 11:18

kabir changed the title ~~Reactive amqp 15405~~ [WFLY-15405] AMQP Connector for reactive messaging Jan 10, 2023

kabir force-pushed the reactive-amqp-15405 branch from 67d8c99 to 68b13d5 Compare March 16, 2023 13:57

kabir force-pushed the reactive-amqp-15405 branch from 68b13d5 to 1a9c7a6 Compare April 4, 2023 11:17

kabir mentioned this pull request Apr 4, 2023

[WFLY-17839] Update mutiny vertx client to 3.0.0 #16689

Merged

kabir force-pushed the reactive-amqp-15405 branch from 1a9c7a6 to 6857ad1 Compare April 4, 2023 11:43

kabir force-pushed the reactive-amqp-15405 branch from 6857ad1 to b18b151 Compare April 21, 2023 11:15

jstourac reviewed May 17, 2023

View reviewed changes

jstourac reviewed May 18, 2023

View reviewed changes

kabir force-pushed the reactive-amqp-15405 branch from 6d18c38 to 97d574c Compare May 18, 2023 10:54

jstourac reviewed May 18, 2023

View reviewed changes

kabir force-pushed the reactive-amqp-15405 branch 3 times, most recently from 477b3f8 to 7589e86 Compare May 22, 2023 13:02

jstourac reviewed May 23, 2023

View reviewed changes

kabir force-pushed the reactive-amqp-15405 branch from 7589e86 to 35e1293 Compare May 23, 2023 12:57

This was referenced Oct 30, 2023

Fix for WFLY-18687, Some add-ons in Galleon layer metadata are missing a description #17338

Merged

Using JMS connector in WildFly with its embedded ActiveMQ server smallrye/smallrye-reactive-messaging#2347

Open

kabir force-pushed the reactive-amqp-15405 branch 2 times, most recently from f14da54 to 67f8e46 Compare November 9, 2023 19:58

kabir removed the rebase-this PR has a merge conflict. label Nov 10, 2023

kabir force-pushed the reactive-amqp-15405 branch from 67f8e46 to 891747a Compare November 10, 2023 13:45

wildfly-bot bot added the rebase-this PR has a merge conflict. label Nov 10, 2023

kabir force-pushed the reactive-amqp-15405 branch 3 times, most recently from d7ad79d to 35a71f7 Compare November 17, 2023 16:16

kabir force-pushed the reactive-amqp-15405 branch 2 times, most recently from 8a57a4c to 7b2cf2a Compare December 8, 2023 16:48

wildfly-bot bot removed the rebase-this PR has a merge conflict. label Dec 8, 2023

kabir force-pushed the reactive-amqp-15405 branch 4 times, most recently from 31cfb8d to f859204 Compare December 11, 2023 12:57

kabir added 2 commits December 14, 2023 10:32

[WFLY-15405] Add support for SmallRye Reactive Messaging AMQP Connector

08b130e

[WFLY-15405] Force property to turn off Google DNS as a fallback

2bb00dd

Google DNS causes problems looking up services in Kubernetes

kabir force-pushed the reactive-amqp-15405 branch from f859204 to 2bb00dd Compare December 14, 2023 11:10

kabir mentioned this pull request Dec 14, 2023

[WFLY-15405] Test for the MP Reactive Messaging AMQP Connnector wildfly-extras/wildfly-cloud-tests#121

Open

darranl reviewed Dec 14, 2023

View reviewed changes

[WFLY-15405] Copyright fixes

1d4a7c4

kabir force-pushed the reactive-amqp-15405 branch from 56b528b to 1d4a7c4 Compare December 14, 2023 16:46

bstansberry reviewed Dec 14, 2023

View reviewed changes

kabir mentioned this pull request Dec 15, 2023

[WFLY-15405][WFLY-18852] AMQP Connector for Reactive Messaging follow-up #17491

Merged

bstansberry approved these changes Dec 15, 2023

View reviewed changes

bstansberry merged commit df398be into wildfly:main Dec 15, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFLY-15405] AMQP Connector for reactive messaging #16281

[WFLY-15405] AMQP Connector for reactive messaging #16281

kabir commented Nov 14, 2022 •

edited

bstansberry commented Nov 14, 2022

kabir commented Nov 15, 2022

github-actions bot commented Nov 15, 2022 •

edited

jstourac left a comment

jstourac left a comment

jstourac May 23, 2023

jstourac May 23, 2023

kabir commented May 23, 2023

mnovak1 commented Dec 12, 2023

darranl Dec 14, 2023

kabir Dec 14, 2023

darranl Dec 14, 2023

bstansberry Dec 14, 2023

kabir Dec 14, 2023

darranl Dec 14, 2023

bstansberry Dec 14, 2023

kabir Dec 15, 2023

kabir Dec 15, 2023

bstansberry Dec 14, 2023

kabir Dec 15, 2023

kabir Dec 15, 2023

bstansberry Dec 14, 2023

kabir Dec 15, 2023

bstansberry commented Dec 15, 2023


		`mp.messaging.outgoing.to.connector=smallrye-amqp` says that we want to use AMQP to back the `to` channel. Note that the value `smallrye-amqp` is SmallRye Reactive Messaging specific, and will only be understood if the AMQP connector is enabled.

		`mp.messaging.outgoing.to.address=my-queue` says that we will send data via `to` channel to the AMQP queue on address called `my-queue`.

	`mp.messaging.outgoing.to.address=my-queue` says that we will send data via `to` channel to the AMQP queue on address called `my-queue`.
	`mp.messaging.outgoing.to.address=my-topic` says that we will send data via `to` channel to the AMQP topic (or queue) on address called `my-topic`.


		`mp.messaging.incoming.from.connector=smallrye-amqp` says that we want to use AMQP to back the `from` channel. As above, the value `smallrye-amqp` is SmallRye Reactive Messaging specific.

		`mp.messaging.incoming.from.address=my-queue` says says that the channel named `from` will read data from the AMQP topic (or queue) on address called `my-topic`.

	`mp.messaging.incoming.from.address=my-queue` says says that the channel named `from` will read data from the AMQP topic (or queue) on address called `my-topic`.
	`mp.messaging.incoming.from.address=my-topic` says that the channel named `from` will read data from the AMQP topic (or queue) on address called `my-topic`.

		@@ -0,0 +1,57 @@
		/*
		* JBoss, Home of Professional Open Source.

		@@ -0,0 +1,74 @@
		/*
		* JBoss, Home of Professional Open Source.

		Next we will briefly discuss each of these entries. Remember the `to` channel is on the `send()` method, and the `from` channel is on the `receive()` method.


		'amqp-host=localhost' '`amqp-port=5672` points the connector to an AMQP broker running on `localhost:5672`. As before we could also have done these for an individual channel by for example specifying `mp.messaging.outgoing.to.host=localhost` instead. If the host is not specified, it defaults to `localhost.

[WFLY-15405] AMQP Connector for reactive messaging #16281

[WFLY-15405] AMQP Connector for reactive messaging #16281

Conversation

kabir commented Nov 14, 2022 • edited

bstansberry commented Nov 14, 2022

kabir commented Nov 15, 2022

github-actions bot commented Nov 15, 2022 • edited

jstourac left a comment

Choose a reason for hiding this comment

jstourac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kabir commented May 23, 2023

mnovak1 commented Dec 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bstansberry commented Dec 15, 2023

kabir commented Nov 14, 2022 •

edited

github-actions bot commented Nov 15, 2022 •

edited