Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-17385 Static and final method verification for bean superclasses #16454

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -58,14 +58,13 @@ public void configure(final DeploymentPhaseContext context, final ComponentDescr
for(ViewDescription view : description.getViews()) {
if(view.getViewClassName().equals(description.getComponentClassName())) {
noInterface = true;
break;
}
}

EjbValidationsUtil.getBusinessMethods(configuration.getComponentClass());

EjbValidationsUtil.verifyEjbClassAndDefaultConstructor(ctor, configuration.getComponentClass().getEnclosingClass(), noInterface, description.getComponentName(), description.getComponentClassName(), configuration.getComponentClass().getModifiers());
EjbValidationsUtil.verifyEjbPublicMethodAreNotFinalNorStatic(configuration.getComponentClass().getDeclaredMethods(),description.getComponentClassName());
EjbValidationsUtil.verifyEjbPublicMethodAreNotFinalNorStatic(configuration.getComponentClass().getMethods(),description.getComponentClassName());
for ( Class<?> interfaceClass : configuration.getComponentClass().getInterfaces())
EjbValidationsUtil.verifyEjbPublicMethodAreNotFinalNorStatic(interfaceClass.getDeclaredMethods(), interfaceClass.getCanonicalName());
EjbValidationsUtil.verifyEjbPublicMethodAreNotFinalNorStatic(interfaceClass.getMethods(), interfaceClass.getCanonicalName());
}
}
Expand Up @@ -124,7 +124,7 @@ public static void verifyEjbClassAndDefaultConstructor(final Constructor<?> ctor
public static boolean verifyEjbPublicMethodAreNotFinalNorStatic(Method[] methods, String classname) {
boolean isEjbCompliant = true;
for (Method method : methods) {
if (Modifier.isPublic(method.getModifiers()) && !EjbValidationsUtil.verifyMethodIsNotFinalNorStatic(method, classname))
if (Object.class != method.getDeclaringClass() && !EjbValidationsUtil.verifyMethodIsNotFinalNorStatic(method, classname))
isEjbCompliant = false;
pferraro marked this conversation as resolved.
Show resolved Hide resolved
}
return isEjbCompliant;
Expand Down