[WFLY-14307] Warning if wrong annotation is added to a Servlet #16542
Conversation
github-actions
bot
added
the
deps-ok
|
@fl4via would you please review? thanks |
| @@ -442,4 +442,8 @@ public interface UndertowLogger extends BasicLogger { | |||
| @Message(id = 110, value = "The use of security realms at runtime is unsupported.") | |||
| OperationFailedException runtimeSecurityRealmUnsupported(); | |||
|
|
|||
| @LogMessage(level = WARN) | |||
| @Message(id = 111, value = "Annotation: '%s' cannot be used on Servlet: '%s'") | |||
There was a problem hiding this comment.
This should say something about what will happen, e.g. the annotation will have no effect (if that's true.)
|
@bstansberry Updated with the suggestion :) |
|
@bstansberry @fl4via Is this good to merge ? I'd like to have an approval so I can merge the downstream one. |
@soul2zimate yes, it is good to go! We probably need to retrigger the cancelled CI though to make sure it passes. |
|
retest this please |
|
It seems I only triggered jobs configured in TeamCity, but I am not able to rerun that Github action |
|
Thanks @gaol, @fl4via and @soul2zimate |
Thanks for submitting your Pull Request!
Please delete this text, and add a link to the Jira issue solved by this PR.
If this PR is not for the 'main' branch you must add a link to the equivalent change in 'main'.
Remember to use the Jira issue ID in the PR title and any commits.
Issue: https://issues.redhat.com/browse/WFLY-14307