[WFLY-17566] Deprecate legacy security attributes in resource adapter subsystem #16557

tadamski · 2023-02-25T11:58:17Z

https://issues.redhat.com/browse/WFLY-17566

bstansberry

@tadamski Sorry it's taken so long to get to this one.

bstansberry · 2023-03-29T02:35:32Z

...rg/jboss/as/connector/services/resourceadapters/DirectConnectionFactoryActivatorService.java

                    } else if (key.equals("ironjacamar.security.domain")) {
-                        securitySettingDomain = value;
+                        SUBSYSTEM_RA_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. I don't think throwing OFE from here is correct; some other exception type is needed.

bstansberry · 2023-03-29T02:35:52Z

...rg/jboss/as/connector/services/resourceadapters/DirectConnectionFactoryActivatorService.java

@@ -186,13 +182,13 @@ public void start(org.jboss.msc.service.StartContext context) throws org.jboss.m
            Security security = null;
            if (securitySetting != null) {
                if ("".equals(securitySetting)) {
-                    security = new SecurityImpl(null, null, false, false);
+                    SUBSYSTEM_RA_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. I don't think throwing OFE from here is correct; some other exception type is needed.

bstansberry · 2023-03-29T02:35:57Z

...rg/jboss/as/connector/services/resourceadapters/DirectConnectionFactoryActivatorService.java

                } else if ("application".equals(securitySetting)) {
-                    security = new SecurityImpl(null, null, true, false);
+                    SUBSYSTEM_RA_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. I don't think throwing OFE from here is correct; some other exception type is needed.

bstansberry · 2023-03-29T02:36:16Z

...s/as/connector/services/resourceadapters/deployment/ResourceAdapterXmlDeploymentService.java

-            } else if (securityDomain == null || securityDomain.trim().equals("")) {
-                return null;
+            if(securityDomain != null){
+                ConnectorLogger.SUBSYSTEM_RA_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. I don't think throwing OFE from here is correct; some other exception type is needed.

bstansberry · 2023-03-29T02:36:48Z

...r/src/main/java/org/jboss/as/connector/subsystems/datasources/AbstractDataSourceService.java

-            } else {
-                return new PicketBoxSubjectFactory(subjectFactory.getValue());
+            if (securityDomain != null) {
+                DS_DEPLOYER_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. I don't think throwing OFE from here is correct; some other exception type is needed.

bstansberry · 2023-03-29T02:38:45Z

...tor/src/main/java/org/jboss/as/connector/subsystems/datasources/DataSourceModelNodeUtil.java

@@ -181,13 +180,14 @@ static ModifiableDataSource from(final OperationContext operationContext, final


        final String securityDomain = ModelNodeUtil.getResolvedStringIfSetOrGetDefault(operationContext, dataSourceNode, SECURITY_DOMAIN);
-        final boolean elytronEnabled = ModelNodeUtil.getBooleanIfSetOrGetDefault(operationContext, dataSourceNode, ELYTRON_ENABLED);
+        if (securityDomain != null) {
+            ConnectorLogger.DS_DEPLOYER_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. Here an OFE is ok.

bstansberry · 2023-03-29T02:39:02Z

...tor/src/main/java/org/jboss/as/connector/subsystems/datasources/DataSourceModelNodeUtil.java

@@ -282,13 +282,14 @@ static ModifiableXaDataSource xaFrom(final OperationContext operationContext, fi
        final String username = ModelNodeUtil.getResolvedStringIfSetOrGetDefault(operationContext, dataSourceNode, USERNAME);
        final String password= ModelNodeUtil.getResolvedStringIfSetOrGetDefault(operationContext, dataSourceNode, PASSWORD);
        final String securityDomain = ModelNodeUtil.getResolvedStringIfSetOrGetDefault(operationContext, dataSourceNode, SECURITY_DOMAIN);
-        final boolean elytronEnabled = ModelNodeUtil.getBooleanIfSetOrGetDefault(operationContext, dataSourceNode, ELYTRON_ENABLED);
+        if (securityDomain != null) {
+            ConnectorLogger.DS_DEPLOYER_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. Here an OFE is ok.

bstansberry · 2023-03-29T02:39:15Z

...tor/src/main/java/org/jboss/as/connector/subsystems/datasources/DataSourceModelNodeUtil.java

@@ -335,7 +336,9 @@ static ModifiableXaDataSource xaFrom(final OperationContext operationContext, fi
        final String recoveryUsername = ModelNodeUtil.getResolvedStringIfSetOrGetDefault(operationContext, dataSourceNode, RECOVERY_USERNAME);
        final String recoveryPassword = ModelNodeUtil.getResolvedStringIfSetOrGetDefault(operationContext, dataSourceNode, RECOVERY_PASSWORD);
        final String recoverySecurityDomain = ModelNodeUtil.getResolvedStringIfSetOrGetDefault(operationContext, dataSourceNode, RECOVERY_SECURITY_DOMAIN);
-        final boolean recoveryElytronEnabled = ModelNodeUtil.getBooleanIfSetOrGetDefault(operationContext, dataSourceNode, RECOVERY_ELYTRON_ENABLED);
+        if(recoverySecurityDomain != null){
+            ConnectorLogger.DS_DEPLOYER_LOGGER.legacySecurityNotSupported();


This method produces an OperationFailedException but it is not thrown. Here an OFE is ok.

bstansberry · 2023-03-29T02:46:09Z

connector/src/main/java/org/jboss/as/connector/logging/ConnectorLogger.java

+    OperationFailedException legacySecurityAttributeNotSupported(String attribute);
+
+    @Message(id = 132, value = "Legacy security is no longer supported. Please use Elytron configuration instead")
+    OperationFailedException legacySecurityNotSupported();


If you change this to OperationFailedRuntimeException it could be thrown from both an OperationStepHandler and from other contexts (like an MSC Service start method) that can properly handle a RuntimeException.

I decided to return a String and create exceptions, which match other exceptions thrown, in the code of those classes

tadamski · 2023-03-30T18:51:18Z

@bstansberry no problems, I have fixed the problems mentioned above

bstansberry · 2023-04-05T22:04:29Z

...s/as/connector/services/resourceadapters/deployment/ResourceAdapterXmlDeploymentService.java

-            } else if (securityDomain == null || securityDomain.trim().equals("")) {
-                return null;
+            if (securityDomain != null) {
+                throw new DeployException(ConnectorLogger.SUBSYSTEM_RA_LOGGER.legacySecurityNotSupported());


@tadamski I suspect this causes test failures because securityMetadata.resolveSecurityDomain() is returning the name of the authentication context (e.g. RaOperationUtil passes that into CredentialImpl.)

bstansberry · 2023-04-05T22:09:53Z

@tadamski You've addressed the issues I saw, but that has resulted in test failures. I think my comment above is the reason for at least one. Some others may just mean some test deployments need updates to not reference legacy security. Others I don't know.

connector/src/main/java/org/jboss/as/connector/subsystems/resourceadapters/Constants.java

…s subsystem

…es from connector

connector/src/main/java/org/jboss/as/connector/subsystems/resourceadapters/RaOperationUtil.java

bstansberry · 2023-05-10T19:56:03Z

Woohoo! Thanks @tadamski and @jamezp!

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Feb 25, 2023

bstansberry requested changes Mar 29, 2023

View reviewed changes

bstansberry added the 28.x label Mar 29, 2023

tadamski force-pushed the WFLY-17566_ra branch from 692c995 to 1fbed98 Compare March 30, 2023 18:47

bstansberry reviewed Apr 5, 2023

View reviewed changes

bstansberry reviewed Apr 18, 2023

View reviewed changes

connector/src/main/java/org/jboss/as/connector/subsystems/resourceadapters/Constants.java Show resolved Hide resolved

bstansberry reviewed Apr 18, 2023

View reviewed changes

connector/src/main/java/org/jboss/as/connector/subsystems/resourceadapters/Constants.java Show resolved Hide resolved

bstansberry reviewed Apr 18, 2023

View reviewed changes

connector/src/main/java/org/jboss/as/connector/subsystems/resourceadapters/Constants.java Show resolved Hide resolved

tadamski force-pushed the WFLY-17566_ra branch 4 times, most recently from e3322b1 to 1c2d6ad Compare April 21, 2023 12:59

bstansberry added 29.Alpha1 and removed 28.x labels Apr 24, 2023

tadamski added 2 commits April 25, 2023 15:36

[WFLY-17566] Deprecate legacy security attributes in resource adapter…

0f03bef

…s subsystem

[WFLY-17566] Messaging: fixes after removing legacy security attribut…

2931239

…es from connector

tadamski force-pushed the WFLY-17566_ra branch from 1c2d6ad to 2931239 Compare April 25, 2023 13:42

Skyllarr reviewed Apr 28, 2023

View reviewed changes

connector/src/main/java/org/jboss/as/connector/subsystems/resourceadapters/RaOperationUtil.java Show resolved Hide resolved

jamezp approved these changes May 10, 2023

View reviewed changes

bstansberry merged commit c5f48f0 into wildfly:main May 10, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFLY-17566] Deprecate legacy security attributes in resource adapter subsystem #16557

[WFLY-17566] Deprecate legacy security attributes in resource adapter subsystem #16557

tadamski commented Feb 25, 2023

bstansberry left a comment

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

bstansberry Mar 29, 2023

tadamski Mar 30, 2023

tadamski commented Mar 30, 2023

bstansberry Apr 5, 2023

tadamski Apr 25, 2023

bstansberry commented Apr 5, 2023

bstansberry commented May 10, 2023

[WFLY-17566] Deprecate legacy security attributes in resource adapter subsystem #16557

[WFLY-17566] Deprecate legacy security attributes in resource adapter subsystem #16557

Conversation

tadamski commented Feb 25, 2023

bstansberry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tadamski commented Mar 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bstansberry commented Apr 5, 2023

bstansberry commented May 10, 2023