[WFLY-17673] Replace javax API module identifiers in DUPs with the ja… #16691
Conversation
| @@ -46,7 +46,7 @@ public class EeSubsystemRootResource extends SimpleResourceDefinition { | |||
|
|
|||
| public static final String WILDFLY_NAMING = "org.wildfly.naming"; | |||
| public static final String JBOSS_INVOCATION = "org.jboss.invocation"; | |||
| public static final String JSON_API = "javax.json.api"; | |||
| public static final String JSON_API = "jakarta.json.api"; | |||
| public static final String GLASSFISH_EL = "org.glassfish.javax.el"; | |||
There was a problem hiding this comment.
org.glassfish.javax.el is an alias of org.glassfish.jakarta.el which is indeed an alias for org.glassfish.expressly, but we are taking into account a limited set of aliases to avoid incompatibilities via exclusions, so I intentionally left it as it is.
| public static final ModuleIdentifier JAXB_API = ModuleIdentifier.create("jakarta.xml.bind.api"); | ||
| public static final ModuleIdentifier JSON_API = ModuleIdentifier.create("jakarta.json.api"); | ||
| public static final ModuleIdentifier JAXRS_API = ModuleIdentifier.create("jakarta.ws.rs.api"); |
There was a problem hiding this comment.
Since these fields are public, I left them as they are without converting them to Strings
There was a problem hiding this comment.
Is the module public or private?
There was a problem hiding this comment.
Good hint, the module is private, so, we are able to modify these fields without worrying about public usage
github-actions
bot
added
the
deps-ok
| ModuleIdentifier.create("javax.jws.api"), | ||
| ModuleIdentifier.create("javax.xml.soap.api"), | ||
| ModuleIdentifier.create("javax.xml.ws.api") |
There was a problem hiding this comment.
javax.jws.api and javax.xml.ws.api are two aliases of jakarta.xml.ws.api
…karta variant name Jira issue: https://issues.redhat.com/browse/WFLY-17673
|
Thanks @yersan |
…karta variant name
Jira issue: https://issues.redhat.com/browse/WFLY-17673