Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-17876] Have the MicroProfile LRA subsystems fully clean up afte… #16717

Merged
merged 1 commit into from Apr 11, 2023
Merged

[WFLY-17876] Have the MicroProfile LRA subsystems fully clean up afte… #16717

merged 1 commit into from Apr 11, 2023

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry marked this pull request as ready for review April 11, 2023 01:19
@bstansberry bstansberry mentioned this pull request Apr 11, 2023
Merged
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 11, 2023
xstefank
xstefank approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just not sure if you wanted to commit also the logging.properties. Thanks.

@bstansberry
Copy link
Contributor Author

@xstefank Thanks. Yes, I did commit the logging.properties intentionally. The client-side test.log that produces was helpful in debugging this issue. Many of our ts modules have those.

@bstansberry bstansberry merged commit 631d45f into wildfly:main Apr 11, 2023
14 checks passed
@bstansberry bstansberry deleted the WFLY-17876 branch April 11, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
2 participants
@bstansberry @xstefank