Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-17901 Duplicated dependencies in module.xml files #16738

Merged
merged 1 commit into from
Apr 17, 2023
Merged

WFLY-17901 Duplicated dependencies in module.xml files #16738

merged 1 commit into from
Apr 17, 2023

Conversation

clara0
Copy link
Contributor

@clara0 clara0 commented Apr 17, 2023

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 17, 2023
xstefank
xstefank approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for LRA part

@xstefank xstefank requested a review from jasondlee April 17, 2023 06:19
jasondlee
jasondlee approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jasondlee jasondlee left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bad merge. Good catch.

@bstansberry bstansberry merged commit d4c3af8 into wildfly:main Apr 17, 2023
6 checks passed
@bstansberry
Copy link
Contributor

Thanks @clara0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondlee jasondlee jasondlee approved these changes

@bstansberry bstansberry bstansberry approved these changes

@xstefank xstefank xstefank approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
4 participants
@clara0 @bstansberry @jasondlee @xstefank