Added Arquillian Test Case for ElytroHttpClient #16761
Conversation
|
Hello, keshav-725. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
|
Hi @keshav-725. We can't use SNAPSHOT dependencies, that said wildfly-core has been updated to 20.0.1.Final so hopefully the changes are in there. |
|
@jamezp The changes are not yet in the wildfly-elytron or wildfly-core as this tests are for a feature. @keshav-725 Can you please write into the description of this PR that it requires your elytron PR ? Thanks! |
bstansberry
added
core-upgrade-needed
|
@keshav-725 Please also file a WFLY JIRA for this and use the JIRA id in the commit message and in the title of this PR. Thanks! You can link the WFLY JIRA to whatever Elytron JIRA is being used to track what this is testing. |
|
@bstansberry I have updated the commit message as well as title of this PR.Also Linked the WFLY JIRA to ELYTRON JIRA.Thanks! |
| ElytronHttpClient elytronHttpClient = new ElytronHttpClient(); | ||
| context.run(() -> { | ||
| try{ | ||
| HttpResponse response = elytronHttpClient.connect(servletUrl.toString()); |
There was a problem hiding this comment.
@keshav-725 It would be good to add some tests that use the same elytronHttpClient instance for different requests in different AuthenticationContext? So something like:
ElytronHttpClient elytronHttpClient = new ElytronHttpClient();
..
AuthenticationContext context1 = ..
AuthenticationContext contex2 = ...
context.run() {...elytronHttpClient.send request..}
context2.run() {...elytronHttpClient.send request2..}
so we know that the elytronHttpClient works in changing authentication contexts. Some test could use a different URI for these requests as well. Let me know if you have any questions about that. Thank you!
|
@keshav-725 @Skyllarr @fjuma @darranl I question the test strategy here. AFAICT this isn't testing WildFly at all, it's testing Elytron. It's just using WildFly as a test server. Can't this be done in the Elytron code base? |
| * License along with this software; if not, write to the Free | ||
| * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA | ||
| * 02110-1301 USA, or see the FSF site: http://www.fsf.org. | ||
| */ |
There was a problem hiding this comment.
This needs to use the current license header (see the other java files.)
|
|
||
| import java.net.MalformedURLException; | ||
| import java.net.URL; | ||
| import java.net.http.HttpResponse; |
There was a problem hiding this comment.
The java.* imports come before the org.jboss ones.
| import java.net.http.HttpResponse; | ||
|
|
||
| @RunWith(Arquillian.class) | ||
| public class DigestAuthnTestCase { |
There was a problem hiding this comment.
This should also have @RunAsClient.
| <property name="serverConfig">${jboss.server.config.file.name:standalone.xml}</property> | ||
| <property name="jbossArguments">${jboss.args}</property> | ||
| <property name="allowConnectingToRunningServer">true</property> | ||
| <property name="managementAddress">${node0:127.0.0.1}</property> | ||
| <property name="managementPort">${as.managementPort:9990}</property> | ||
| <property name="javaVmArguments">${server.jvm.args} -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n</property> |
There was a problem hiding this comment.
This change should be removed.
|
Closing this PR for now as nobody is working on it currently |
https://issues.redhat.com/browse/WFLY-17938
Requires : https://issues.redhat.com/browse/ELY-201 which has PR : wildfly-security/wildfly-elytron#1881