Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-17973] Clean up appclient Main #16796

Merged
merged 1 commit into from Apr 30, 2023
Merged

[WFLY-17973] Clean up appclient Main #16796

merged 1 commit into from Apr 30, 2023

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry commented Apr 28, 2023 •
edited

https://issues.redhat.com/browse/WFLY-17973

Blocks wildfly/wildfly-core#5479

The key bits are the changes to ProductInfo and ServerEnvironment constructors; the rest is just IDE warn housekeeping.

@bstansberry bstansberry mentioned this pull request Apr 28, 2023
Merged
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 28, 2023
@bstansberry bstansberry merged commit e919ff4 into wildfly:main Apr 30, 2023
13 of 14 checks passed
@bstansberry bstansberry deleted the WFLY-17973 branch April 30, 2023 14:06
@bstansberry
Copy link
Contributor Author

Thanks @jamezp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

Assignees
No one assigned
Labels
29.Alpha1 deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
2 participants
@bstansberry @jamezp