[WFLY-17991] / [WFLY-17976] ee-security should depend on elytron and ensure the JACC policy is enabled by default. #16812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a choice between elytron and legacy security. As microprofile-jwt has a dependency on ee-security it no longer needs it's own elytron dependency.
…ation. This was not previously default as legacy security also provided this. When the ee-security layer is provisioned this policy should also be activated. The test case no longer needs to activate the policy once it is on by default.
github-actions
bot
added
the
deps-ok
fjuma
reviewed
May 5, 2023
| ---- | ||
| [standalone@localhost:9990 /] reload | ||
| ---- | ||
| specification. This policy provider is active default in the default |
There was a problem hiding this comment.
s/active default/active by default
fjuma
approved these changes
May 5, 2023
The policy is now a part of the default configuration.
bstansberry
approved these changes
May 9, 2023
|
@darranl Failures seem to be related. |
|
Hopefully that fix does it. One thing I have noticed I am sure we used to fail earlier but a lot of tests now are just ignoring set up failures and ploughing on so we end up with a cryptic test failure after the set up failed rather than an error reporting what went wrong during set up so we can jump straight to the point that needs a fix. |
|
Added ready-for-merge label as this has two reviews and CI is now green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-17991
https://issues.redhat.com/browse/WFLY-17976