[WFLY-18009] Add jars needed for compression of Kafka #16826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-changed
|
Dependency Tree Analyzer Output: New Dependencies:
CC @wildfly/prod |
xstefank
approved these changes
May 11, 2023
|
@xstefank One of them used logging in the source code, but really it was just an old habit. I guess the log manager stuff we do on boot works anyway, and whatever was using logging was using JUL so perhaps it will work without. What did you mean by 'year'? :-) |
kabir
force-pushed
the
kafka-add-compression
branch
from
0c7f941
to
b7a1363
Compare
|
@xstefank it worked locally without the logging dependencies, so I have removed them |
xstefank
reviewed
May 11, 2023
.../integration/microprofile/reactive/messaging/kafka/compression/CompressionMessagingBean.java
Outdated
Show resolved
Hide resolved
kabir
force-pushed
the
kafka-add-compression
branch
from
b7a1363
to
38fe2c5
Compare
kabir
force-pushed
the
kafka-add-compression
branch
from
38fe2c5
to
4507a23
Compare
kabir
force-pushed
the
kafka-add-compression
branch
from
4507a23
to
8abcf53
Compare
bstansberry
approved these changes
Sep 21, 2023
|
/retest |
1 similar comment
|
/retest |
kabir
force-pushed
the
kafka-add-compression
branch
from
8abcf53
to
ae2b283
Compare
|
@bstansberry I fixed the compile error locally after a rebase. Should be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-18009