Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-18066 ByteBufferMarshalledValue generates duplicate buffers during a single marshalling operation #16886

Merged
merged 6 commits into from May 31, 2023
Merged

WFLY-18066 ByteBufferMarshalledValue generates duplicate buffers during a single marshalling operation #16886

merged 6 commits into from May 31, 2023

Conversation

pferraro
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label May 26, 2023
@pferraro pferraro added the hold PR should not be merged for some reason. label May 28, 2023
@pferraro
Copy link
Contributor Author

Added hold label while I finish the unit test.

@pferraro pferraro removed the hold PR should not be merged for some reason. label May 30, 2023
@pferraro pferraro requested a review from bstansberry May 30, 2023 22:50
bstansberry
bstansberry approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pferraro -- the comments are very helpful.

@darranl darranl added the ready-for-merge Only for use by those with merge permissions! label May 31, 2023
@bstansberry bstansberry merged commit c23bba1 into wildfly:main May 31, 2023
14 checks passed
@bstansberry
Copy link
Contributor

Thanks @pferraro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
29.Alpha1 deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
3 participants
@pferraro @bstansberry @darranl