Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WFLY-18222, Add some metadata to Galleon layers to allow for layers discovery #17002

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

jfdenise
Copy link
Contributor

@jfdenise jfdenise commented Jul 6, 2023

Issue: https://issues.redhat.com/browse/WFLY-18222

Bumping Galleon and WildFly Bootable JAR versions. Required for this new metadata parsing at provisioning time.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jul 6, 2023
@bstansberry bstansberry requested a review from kabir July 6, 2023 21:52
@bstansberry
Copy link
Contributor

@kabir This seems fine,but can you give it a look? You seem like the person most likely to notice anything wrong.

@jfdenise
Copy link
Contributor Author

jfdenise commented Jul 7, 2023

The failure of the cloud testsuite requires a new release of wildfly maven plugin with dependency on Galleon 5.2.0.
Tracked by: https://issues.redhat.com/browse/WFMP-212

Copy link
Contributor

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfdenise is it possible to release the plugin? Then we can rerun the cloud tests and merge this

@jfdenise
Copy link
Contributor Author

jfdenise commented Jul 7, 2023

@kabir , I pinged @jamezp for the plugin release.

@jamezp
Copy link
Member

jamezp commented Jul 7, 2023

I released 4.2.0.Alpha1 of the plugin https://github.com/wildfly/wildfly-maven-plugin/releases/tag/4.2.0.Alpha1

@jfdenise
Copy link
Contributor Author

@jamezp Thank-you, cloud tests are passing now.

Copy link
Contributor

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes now following wildfly-extras/wildfly-cloud-tests#63

@bstansberry bstansberry merged commit ab87671 into wildfly:main Jul 11, 2023
14 checks passed
@bstansberry
Copy link
Contributor

Thanks @jfdenise @jamezp and @kabir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
4 participants