WFLY-18279 Update HostExcludesTestCase configuration to work with WF30 #17038
Conversation
github-actions
bot
added
the
deps-ok
| WILDFLY_29_0("WildFly29.0", WILDFLY_28_0, true), | ||
| CURRENT(MAJOR, WILDFLY_29_0, getCurrentAddedExtensions(), getCurrentRemovedExtensions(), true); |
There was a problem hiding this comment.
Just for the record, it is good to have it adjusted now (even if the product version is still 29) but it's not strictly necessary to do it on each new release if we have not added/removed extensions on the current release.
The test won't fail if we have moved the product version to the next one (e.g. 30) but we have not added/removed extensions on the current release (e.g. 29).
There was a problem hiding this comment.
Without this change, it seems that all full-integration tests on wildfly-core are failing, e.g. https://ci.wildfly.org/viewLog.html?buildId=381306&buildTypeId=WildFlyCore_PullRequest_WildFlyCoreFullIntegrationLinuxJdk11
as well as CI runs for wildfly itself, e.g. https://ci.wildfly.org/viewLog.html?buildId=381292&buildTypeId=WF_PullRequest_LinuxJdk11
Was I mistaken?
There was a problem hiding this comment.
The test won't fail if we have moved the product version to the next one (e.g. 30) but we have not added/removed extensions on the current release (e.g. 29).
Ah - I see. So, were the product version changed (I assume, via an update to org.wildfly.core:wildfly-version + a wildfly-core upgrade?), this PR would not have been strictly necessary. Correct?
There was a problem hiding this comment.
Ups, sorry, I missed this comment and my review was incorrect since there were extensions removed in the current release (WF29).
|
Thanks, @pferraro. Can I punish you for doing this by asking you to update the WF release process doc to include this as an aspect of the "bump the version" release task? This is something I should do as part of the version bump commit but I never remember! |
Sure, no problem. |
|
@yersan Was I also meant to have moved the extensions referenced within getCurrentRemovedExtensions() to the enum value for WILDFLY_29_0? |
|
@pferraro Yes, right, I missed those extensions. They were removed, so we need to move them as removed extensions for the new enum we are creating. If we don't move them, the test will fail as soon as we moved the major version in the pom.xml: see https://github.com/wildfly/wildfly/pull/17038/files#diff-d4696c308808a57f331264e1d20639f0ef8a33968635726f1d64a3ecb14e93d5L387-L389 This is how the test forces us to keep the enums in sync with what we have ... sadly it creates more headaches than other things |
|
See pferraro#13 these are the additional changes required for this PR |
|
@yersan PR updated to include modules removed in WF29. |
|
Hi @pferraro, a check style issue: "[20:01:33]W: [Step 5/6] [ERROR] /opt/buildAgent/work/e34a6f994de9f7c6/testsuite/domain/src/test/java/org/jboss/as/test/integration/domain/HostExcludesTestCase.java:39:8: Unused import - java.util.Collections. [UnusedImports]" |
https://issues.redhat.com/browse/WFLY-18279