Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-18163] Add org.wildfly.extension.elytron.jaas-realm module exclusion #17044

Closed
wants to merge 2 commits into from
Closed

[WFLY-18163] Add org.wildfly.extension.elytron.jaas-realm module exclusion #17044

wants to merge 2 commits into from

Conversation

Skyllarr
Copy link
Contributor

@Skyllarr Skyllarr commented Jul 25, 2023 •
edited

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jul 25, 2023
@Skyllarr Skyllarr requested a review from fjuma July 26, 2023 14:46
@Skyllarr
Copy link
Contributor Author

@OndrejKotek Thank you for review!

@Skyllarr Skyllarr changed the title [WFLY-18163] Tests for JaasSecurityRealm via a custom-realm resource [WFLY-18163] Add org.wildfly.extension.elytron.jaas-realm module exclusion and tests for JaasSecurityRealm via a custom-realm resource Aug 22, 2023
@Skyllarr Skyllarr mentioned this pull request Aug 22, 2023
Closed
@yersan yersan added the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Sep 20, 2023
@wildfly-bot wildfly-bot bot requested a review from yersan October 16, 2023 15:14
fjuma
fjuma approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Skyllarr! Approving these changes. We'll need to discuss how to coordinate getting wildfly/wildfly-core#5587 merged once pre-checked since CI passing will depend on the exclusions that are being added in this PR.

@wildfly-bot wildfly-bot bot requested a review from fjuma November 17, 2023 10:39
@fjuma fjuma mentioned this pull request Nov 17, 2023
Merged
@Skyllarr Skyllarr changed the title [WFLY-18163] Add org.wildfly.extension.elytron.jaas-realm module exclusion and tests for JaasSecurityRealm via a custom-realm resource [WFLY-18163] Add org.wildfly.extension.elytron.jaas-realm module exclusion Nov 17, 2023
@Skyllarr Skyllarr mentioned this pull request Nov 17, 2023
Closed
@Skyllarr
Copy link
Contributor Author

I have split this PR so that the CI passes on this one. The test was moved to the new PR #17417 .

It might be easier to coordinate the merges with wildfly/wildfly-core#5587

@Skyllarr
Copy link
Contributor Author

Hi @yersan , I was trying to make HostExcludesTestCase work, so I created WFLY-18764 issue and included its commit in this PR. But now I can't get pass the below error in "Thin Server Build":

Invalid value WildFly30.0 for host-release; legal values are [WildFly23.0, WildFly24.0, WildFly25.0, WildFly26.0, WildFly20.0, WildFly21.0, WildFly22.0, WildFly27.0, WildFly28.0, WildFly29.0, WildFly12.0, WildFly13.0, WildFly14.0, WildFly15.0, WildFly10.0, WildFly10.1, WildFly11.0, EAP6.3, EAP7.2, EAP6.2, EAP7.1, EAP7.0, WildFly16.0, WildFly17.0, EAP7.4, WildFly18.0, EAP6.4, EAP7.3, WildFly19.0]"}}}
at org.wildfly.galleon.plugin.config.generator.BaseConfigGenerator.doHandle(BaseConfigGenerator.java:144)
at org.wildfly.galleon.plugin.config.generator.BaseConfigGenerator.endBatch(BaseConfigGenerator.java:162)
at org.wildfly.galleon.plugin.config.generator.ForkedConfigGenerator.executeScript(ForkedConfigGenerator.java:63)
at org.wildfly.galleon.plugin.config.generator.ForkedConfigGenerator.forkedForEmbedded(ForkedConfigGenerator.java:45)
at org.wildfly.galleon.plugin.server.ForkedProcessRunner.main(ForkedProcessRunner.java:56)

do you happen to know why the WildFly30.0 is not an allowed value? Thanks a lot!

@yersan
Copy link
Contributor

yersan commented Nov 20, 2023

Hi @Skyllarr , the changes in the HostExclusion test case and domain exclusions look good, the issue you are facing is that we have not updated WildFly Core to the management API used by WildFly 31. This will be done at https://issues.redhat.com/browse/WFCORE-6620, we plan to release it this Wednesday at most.

@Skyllarr
Copy link
Contributor Author

@yersan I see, thank you very much for explanation and for looking at my HostExcludesTestCase changes!

darranl
darranl reviewed Nov 22, 2023
View reviewed changes
testsuite/shared/src/main/java/org/jboss/as/test/shared/LayersTestBase.java
@@ -53,6 +53,7 @@ public abstract class LayersTestBase {
"org.hornetq.client",
// TODO we need to add an xts layer
"org.jboss.as.xts",
"org.wildfly.extension.elytron.jaas-realm",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has needed more additions but in general could it be useful if the LatestTest got some of these items directly from a class in WildFly Core so when changes are made to WildFly Core we reduce the number of round trips to get something merged.

@Skyllarr
Copy link
Contributor Author

/retest

@Skyllarr Skyllarr mentioned this pull request Feb 13, 2024
Merged
@yersan
Copy link
Contributor

yersan commented Feb 16, 2024

Superseded by #17622, already merged

@yersan yersan closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darranl darranl darranl approved these changes

@OndrejKotek OndrejKotek OndrejKotek left review comments

@fjuma fjuma fjuma approved these changes

@yersan yersan Awaiting requested review from yersan

Assignees
No one assigned
Labels
core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
5 participants
@Skyllarr @yersan @darranl @fjuma @OndrejKotek