Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-18296] Remove the org.jboss.jts dependency on jdk.console #17051

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[WFLY-18296] Remove the org.jboss.jts dependency on jdk.console #17051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4273a3
[WFLY-18296] Remove the org.jboss.jts dependency on jdk.console
bstansberry Jul 30, 2023
c40fee8
[WFLY-18296]:change the jdk.compiler dependency as optional as this i…
jimma Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n-shared/src/main/resources/modules/system/layers/base/org/glassfish/jaxb/main/module.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<module name="java.xml"/>
<module name="jakarta.activation.api"/>
<module name="jakarta.xml.bind.api"/>
<module name="jdk.compiler"/>
<module name="jdk.compiler" optional="true"/>
</dependencies>

</module>
13 changes: 13 additions & 0 deletions ...alleon-shared/src/main/resources/modules/system/layers/base/org/jboss/jts/main/module.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,20 @@
<module name="java.transaction.xa"/>
<module name="java.xml"/>
<module name="jakarta.transaction.api"/>
<!--
The jdk.console module is a compile dependency of narayana-jts-idlj
but is not a runtime one within WildFly. It's listed here with
this comment to prevent it being re-added as a dependency
without discussion.

Narayana has a 'TxPerfPlugin' JConsolePlugin implementation but
WildFly does not support running JConsole as a modular application.

WildFly should not have dependencies on JDK modules that are not
associated with the traditional 'JRE' concept.

<module name="jdk.jconsole"/>
-->
<module name="org.omg.api" />
<module name="org.jboss.logging"/>
<module name="org.jboss.jts.integration"/>
Expand Down