-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-18353] Update TestCustomPrincipalTransformer to no longer rely on the Elytron subsystem #17104
Conversation
/cc @fjuma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cam-rod! Just a very minor comment, would be good to update the commit message and issue title to something like "Update the TestCustomPrincipalTransformer to no longer rely on the elytron subsystem".
Would you be able to check if we can also remove the org.wildfly.core.wildfly-elytron-integration
test dependency now too?
Updated the title and removed the subsystem dependency |
@cam-rod Looks like there are some compilation failures. |
…on the Elytron subsystem Remove dependency on org.wildfly.core:wildfly-elytron-integration
Thanks for the heads up, looks like the CredentialStore tests were trying to reuse a subsystem error message. I directly copied the string over and everything seems fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cam-rod!
https://issues.redhat.com/browse/WFLY-18353
This fix is also needed to fully implement wildfly/wildfly-core#5561.