Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18353] Update TestCustomPrincipalTransformer to no longer rely on the Elytron subsystem #17104

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

cam-rod
Copy link
Contributor

@cam-rod cam-rod commented Aug 14, 2023

https://issues.redhat.com/browse/WFLY-18353

This fix is also needed to fully implement wildfly/wildfly-core#5561.

@wildfly-bot
Copy link

wildfly-bot bot commented Aug 14, 2023

/cc @fjuma

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cam-rod! Just a very minor comment, would be good to update the commit message and issue title to something like "Update the TestCustomPrincipalTransformer to no longer rely on the elytron subsystem".

Would you be able to check if we can also remove the org.wildfly.core.wildfly-elytron-integration test dependency now too?

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Aug 14, 2023
@cam-rod cam-rod changed the title [WFLY-18353] Make the org.wildfly.extension.elytron module private [WFLY-18353] Remove dependency on org.wildfly.core:wildfly-elytron-integration Aug 15, 2023
@cam-rod
Copy link
Contributor Author

cam-rod commented Aug 15, 2023

Thanks @cam-rod! Just a very minor comment, would be good to update the commit message and issue title to something like "Update the TestCustomPrincipalTransformer to no longer rely on the elytron subsystem".

Would you be able to check if we can also remove the org.wildfly.core.wildfly-elytron-integration test dependency now too?

Updated the title and removed the subsystem dependency

@cam-rod cam-rod changed the title [WFLY-18353] Remove dependency on org.wildfly.core:wildfly-elytron-integration [WFLY-18353] Update TestCustomPrincipalTransformer to no longer rely on the Elytron subsystem Aug 15, 2023
@fjuma
Copy link
Contributor

fjuma commented Aug 15, 2023

@cam-rod Looks like there are some compilation failures.

…on the Elytron subsystem

Remove dependency on org.wildfly.core:wildfly-elytron-integration
@cam-rod
Copy link
Contributor Author

cam-rod commented Aug 15, 2023

Thanks for the heads up, looks like the CredentialStore tests were trying to reuse a subsystem error message. I directly copied the string over and everything seems fine now.

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cam-rod!

@bstansberry bstansberry merged commit 83dabc7 into wildfly:main Aug 17, 2023
15 checks passed
@bstansberry
Copy link
Contributor

Thanks @cam-rod and @fjuma

@cam-rod cam-rod deleted the WFLY-18353 branch August 20, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
3 participants