-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-18351 Optimize metadata mapping for distributed @Stateful EJBs #17106
Conversation
c84d9bf
to
20f41c6
Compare
61b6c49
to
25c63fd
Compare
279a672
to
8c94fcb
Compare
05481f9
to
2040a68
Compare
Rebased against main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look at the key changes to metadata access using the compute function approach. Looks good.
import org.wildfly.clustering.ejb.bean.BeanExpiration; | ||
import org.wildfly.clustering.ejb.bean.BeanMetaData; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what sense is this a default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add javadoc here.
import org.wildfly.clustering.ee.cache.offset.Offset; | ||
import org.wildfly.clustering.ee.cache.offset.OffsetValue; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what sense is this a default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add javadoc here.
import org.wildfly.clustering.ejb.bean.BeanExpiration; | ||
import org.wildfly.clustering.ejb.bean.ImmutableBeanMetaData; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what sense is this a default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add javadoc here.
import org.wildfly.clustering.ejb.bean.BeanExpiration; | ||
import org.wildfly.clustering.ejb.bean.BeanMetaData; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add javadoc here.
import org.wildfly.clustering.ee.cache.offset.OffsetValue; | ||
import org.wildfly.clustering.ee.cache.offset.Value; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add javadoc here.
https://issues.redhat.com/browse/WFLY-18351
Requires #17096