Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-18351 Optimize metadata mapping for distributed @Stateful EJBs #17106

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

pferraro
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Aug 15, 2023
@pferraro pferraro force-pushed the WFLY-18351 branch 2 times, most recently from c84d9bf to 20f41c6 Compare August 23, 2023 20:04
@pferraro pferraro force-pushed the WFLY-18351 branch 3 times, most recently from 61b6c49 to 25c63fd Compare August 29, 2023 13:13
@pferraro pferraro force-pushed the WFLY-18351 branch 2 times, most recently from 279a672 to 8c94fcb Compare September 6, 2023 15:51
@pferraro pferraro force-pushed the WFLY-18351 branch 3 times, most recently from 05481f9 to 2040a68 Compare October 4, 2023 15:09
@pferraro pferraro added the 30.x label Oct 4, 2023
@pferraro
Copy link
Contributor Author

pferraro commented Oct 5, 2023

Rebased against main.

Copy link
Contributor

@rachmatowicz rachmatowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the key changes to metadata access using the compute function approach. Looks good.

import org.wildfly.clustering.ejb.bean.BeanExpiration;
import org.wildfly.clustering.ejb.bean.BeanMetaData;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what sense is this a default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add javadoc here.

import org.wildfly.clustering.ee.cache.offset.Offset;
import org.wildfly.clustering.ee.cache.offset.OffsetValue;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what sense is this a default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add javadoc here.

import org.wildfly.clustering.ejb.bean.BeanExpiration;
import org.wildfly.clustering.ejb.bean.ImmutableBeanMetaData;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what sense is this a default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add javadoc here.

import org.wildfly.clustering.ejb.bean.BeanExpiration;
import org.wildfly.clustering.ejb.bean.BeanMetaData;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add javadoc here.

import org.wildfly.clustering.ee.cache.offset.OffsetValue;
import org.wildfly.clustering.ee.cache.offset.Value;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add javadoc here.

@pferraro pferraro merged commit 3a0c6b4 into wildfly:main Oct 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
2 participants