WFLY-18457 Remove custom ThreadGroup from Weld's executor services #17193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2023
github-actions
bot
added
the
deps-ok
manovotn
changed the title
bstansberry
approved these changes
Sep 19, 2023
|
Thanks for the review and your investigation into this topic Brian! |
|
Thanks @manovotn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WFLY Jira - https://issues.redhat.com/browse/WFLY-18457
This is linked to a WELD Jira, namely WELD-2755 which attempts to remove custom thread groups from Weld as we do not leverage them in any way and there is a memory leak connected to them (see the linked issue).
Weld PR with the same goal - weld/core#2881