[WFLY-17309]: Upgrade Apache Artemis to 2.31.0 #17202
Conversation
ehsavoie
force-pushed
the
WFLY-17309
branch
from
50e0779
to
4d979ca
Compare
* Upgrading to Apache Artemis 2.31.0 * Upgrading Artemis native to 2.0.0 * Upgrading wildfly-artemis-integration to 2.0.2.Final * Fixing json response changes in Artemis 2.28 Jira: https://issues.redhat.com/browse/WFLY-17309 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
…th paging. * Defining legacy behavior on paging through AddressSettings Jira: https://issues.redhat.com/browse/WFLY-17700 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Upgrading to 16.0 to prepare for management model changes Jira: https://issues.redhat.com/browse/WFLY-18004 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
force-pushed
the
WFLY-17309
branch
from
4d979ca
to
efbe7bb
Compare
github-actions
bot
added
the
deps-changed
|
Dependency Tree Analyzer Output: Major Version Changes:
CC @wildfly/prod |
…bytes. * Adding a new *max-read-page-bytes* attribute to be able to configure Artemis accordingly. Jira: https://issues.redhat.com/browse/WFLY-18000 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
force-pushed
the
WFLY-17309
branch
from
efbe7bb
to
741908b
Compare
|
@bstansberry the 2 failures aren't related |
| @@ -124,6 +124,13 @@ public class AddressSettingDefinition extends PersistentResourceDefinition { | |||
| .setAllowExpression(true) | |||
| .build(); | |||
|
|
|||
| public static final SimpleAttributeDefinition MAX_READ_PAGE_BYTES = create("max-read-page-bytes", ModelType.INT) | |||
| .setDefaultValue(new ModelNode(-1)) | |||
There was a problem hiding this comment.
Is this the right default, versus, say, no default? Artemis defaults to 2 * PAGE_SIZE_BYES.
Using the legacy value -1 saves us a potential server config migration issue, but at the cost of being stuck with -1 for a long time.
BTW the handling of default values for a number of attributes (including PAGE_SIZE_BYES) is incorrect in AddressSettings.createSettings. It checks if the relevant ModelNode is defined and if not it ignores the default.
There was a problem hiding this comment.
Note that I don't pretend to understand all this, but does https://github.com/apache/activemq-artemis/pull/4552/files address one of the concerns with not using -1, i.e. that the server might silently stop processing?
There was a problem hiding this comment.
- I agree we can do this but that will require users to set a proper value or they might meet with https://issues.redhat.com/browse/WFLY-17700
- I've created https://issues.redhat.com/browse/WFLY-18547 to track that
There was a problem hiding this comment.
Ok, thanks. We talked and I'm ok with this or with some other default or even no default (which you don't think is a good idea, which is fine.)
Note also that we can tweak this between now and 30 Final in 2 weeks. But we should be get some form of this in by tomorrow or it should likely wait for WF 31.
|
@mnovak1 WDYT about the default value ? Do you agree with this PR ? |
|
Thanks @ehsavoie |
Issue:
https://issues.redhat.com/browse/WFLY-17309
https://issues.redhat.com/browse/WFLY-17700
https://issues.redhat.com/browse/WFLY-18004
https://issues.redhat.com/browse/WFLY-18000