[WFLY-18642] reevaluated ts.preview and ts.bootable.preview profiles #17290
Conversation
| @@ -389,6 +389,8 @@ | |||
| <!--Dependencies for lra specs --> | |||
| <layer>microprofile-lra-coordinator</layer> | |||
| <layer>microprofile-lra-participant</layer> | |||
| <!-- ts.bootable.preview tests require this --> | |||
| <layer>microprofile-rest-client</layer> | |||
There was a problem hiding this comment.
@bstansberry I couldn't realize why ts.bootable.preview is missing org.eclipse.microprofile.restclient module. It seems wildfly-preview-expansion-bom inherits it from wildfly-common-expansion-dependency-management, but when running with ts.bootable.preview, the test-wildfly.jar is missing it (while with ts.bootable it is there as expected).
There was a problem hiding this comment.
Thanks, @istudens for pointing this out!
This is actually a bug in WFP: https://issues.redhat.com/browse/WFLY-18702.
Other than this change, which shouldn't be needed when that bug is fixed, this PR LGTM. But the CI run is out of date, so what I'm going to do is take your branch and add a commit fixing WFLY-18702, which will include removing these 2 lines. I'll send that up and it will get fresh CI.
|
@bstansberry Can you review this please? Thanks |
github-actions
bot
added
the
deps-ok
Issue: https://issues.redhat.com/browse/WFLY-18642