WFLY-18823 Fix Flaky AbstractValidationUnitTest #17472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der with LinkedHashMaps for JBOSS_SCHEMAS_MAP and CURRENT_JBOSS_SCHEMAS_MAP
|
Hello, alexbadia1. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
|
/ok-to-test |
bstansberry
reviewed
Dec 5, 2023
| @@ -152,6 +154,7 @@ public class AbstractValidationUnitTest { | |||
| final File schemaDir = new File(JBOSS_DIST_DIR, SCHEMAS_LOCATION); | |||
|
|
|||
| final File[] xsds = schemaDir.listFiles(new SchemaFilter(EXCLUDED_SCHEMA_FILES.toArray(new String[0]))); | |||
| Arrays.sort(xsds); | |||
There was a problem hiding this comment.
@alexbadia1 How does this address the JIRA description statement that:
"the order of the SCHEMA_SOURCES matters since some schemas may be dependent on each other, (i.e. one schema importing another)" ?
It makes the order deterministic, but I'm not sure why lexicographical ordering of path names results in avoiding incorrect orders between dependent schemas.
I think your PR's fine; being deterministic is good, and if it passes we know the lexicographical sort order is an ok one to stick to.
|
Thanks @alexbadia1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/WFLY-18823
In AbstractValidationUnitTes list schema files in a deterministic order and preserve order with LinkedHashMaps for JBOSS_SCHEMAS_MAP and CURRENT_JBOSS_SCHEMAS_MAP