[WFLY-18935] JCA: resource adapters subsystem services refactor #17546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-18935
@pferraro this is a PR with the refactor after the review in #17512, but I have only split services into two, so that they are imho better named and encapsulated, but it seems to me that the dependency mechanism here is correct. For the reference it was introduced in https://issues.redhat.com/browse/WFLY-1701 to make sure that RA deployment DUPs don't run only after necessary services are present. I have also looked at another usage of org.jboss.as.server.deployment#addDeploymentDependency it seems pretty similiar to me to what is done in this case.