[WFLY-18952] Migrate operations for MP OpenTracing and MP Metrics are failing #17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
requested changes
Jan 25, 2024
There was a problem hiding this comment.
This won't work as readResourceFromRoot(address, false) will return a resource that has no grandchildren (the javadoc explains the details). So root.navigate will not work properly in a domain, where the subsystem resource is a grandchild of the root, not a child.
My specific comments below will fix it.
...extension/src/main/java/org/wildfly/extension/microprofile/opentracing/MigrateOperation.java
Outdated
Show resolved
Hide resolved
...extension/src/main/java/org/wildfly/extension/microprofile/opentracing/MigrateOperation.java
Outdated
Show resolved
Hide resolved
...extension/src/main/java/org/wildfly/extension/microprofile/opentracing/MigrateOperation.java
Outdated
Show resolved
Hide resolved
...extension/src/main/java/org/wildfly/extension/microprofile/opentracing/MigrateOperation.java
Show resolved
Hide resolved
… failing Correct the path handling code in the migrate ops Fix typo on extension name for MP Metrics
Changes made and pushed. |
emmartins
approved these changes
Jan 26, 2024
|
@bstansberry did you want to take another look? If not I will probably go ahead with a merge in the morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-18952
Correct the path handling code in the migrate ops
Fix typo on extension name for MP Metrics