[WFLY-18973] JDR should collect .yaml files in the .installation folder #17572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyrkob
reviewed
Jan 31, 2024
| new CollectFiles("*/.installation/*.txt"), | ||
| new CollectFiles("*/.installation/*.yaml"), | ||
| new CollectFiles("*/.installation/*.yml"), // currently none without the 'a', but having this makes collection more future proof |
There was a problem hiding this comment.
it might make sense to include .installation/*.xml to capture installation/provisioning_record.xml and .galleon/*.xml
or are they already included by new CollectFiles("*.xml") ?
There was a problem hiding this comment.
@spyrkob Yes, they are already included.
|
Closing as Brad had already sent a similar PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-18973