Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-19167] war containing JDBC drivers deploys an extra driver #17760

Merged
merged 2 commits into from Apr 15, 2024
Merged

[WFLY-19167] war containing JDBC drivers deploys an extra driver #17760

merged 2 commits into from Apr 15, 2024
+163 −6

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Mar 26, 2024 •
edited by wildfly-bot bot

@wildfly-bot wildfly-bot bot requested a review from tadamski March 26, 2024 04:06
@The-Huginn
Copy link

Apologies for the spam in the description by the wildfly-bot 😅 . We accidentally had 2 versions deployed, updating one's another actions. Please feel free to remove all the clutter from the description.

@gaol
Copy link
Contributor Author

gaol commented Mar 26, 2024

no worries @The-Huginn :)

tadamski
tadamski suggested changes Mar 28, 2024
View reviewed changes
...sic/src/test/java/org/jboss/as/test/integration/jca/datasource/JdbcDriversInWarTestCase.java

@Test
public void testJdbcDrivers() throws Exception {
String driverName = DEPLOYMENT;
Copy link
Contributor

@tadamski tadamski Mar 28, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaol maybe it will also be useful to verify the number of deployed drivers? IIUC if there was a short name driver at index '2' the test will pass so maybe we could guard from this....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, good catch !
will try to get the jdbc driver using short name and it should fail.
checking number of deployed jdbc drivers maybe confusing as we need to filter out the default h2 driver.

@gaol
Copy link
Contributor Author

gaol commented Mar 29, 2024

updated according to the feedback by checking if the jdbc driver with the short name is not installed. please review again, @tadamski thanks :)

tadamski
tadamski approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@tadamski tadamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaol LGTM now. Thanks for fixing it!

@bstansberry
Copy link
Contributor

/retest

@bstansberry bstansberry added the 32.x WildFly 32 label Apr 10, 2024
@bstansberry bstansberry merged commit 9243568 into wildfly:main Apr 15, 2024
13 checks passed
@bstansberry
Copy link
Contributor

Thanks @gaol and @tadamski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadamski tadamski tadamski approved these changes

Assignees
No one assigned
Labels
32.x WildFly 32
Projects
None yet
Milestone
No milestone
4 participants
@gaol @The-Huginn @bstansberry @tadamski