Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19267] Support running the standard WildFly testsuite against installations provisioned with the 'latest standard channels' #17838

Merged
merged 2 commits into from Apr 28, 2024

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry commented Apr 22, 2024

https://issues.redhat.com/browse/WFLY-19267

This builds on #17799, which deals with a similar use case. The WFLY-19214 approach there is more flexible but more verbose in cases where the latest version of standard channels manifests are wanted.


<--- THIS SECTION IS AUTOMATICALLY GENERATED BY WILDFLY GITHUB BOT. ANY MANUAL CHANGES WILL BE LOST. --->

Wildfly issue links:

<--- END OF WILDFLY GITHUB BOT REPORT --->

More information about the wildfly-bot[bot]

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 22, 2024
Comment on lines +1519 to +1534
<configuration>
<channels>
<channel>
<manifest>
<groupId>${channels.maven.groupId}</groupId>
<artifactId>wildfly-ee</artifactId>
</manifest>
</channel>
<channel>
<manifest>
<groupId>${channels.maven.groupId}</groupId>
<artifactId>wildfly</artifactId>
</manifest>
</channel>
</channels>
</configuration>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no wildfly-preview channel attached here, so I'm not sure how the expected channels would be injected when this plugin configuration is merged with the one on preview/build.

Would it become an issue?

I guess the same is applied to the ee-build. The plugin configuration merged will attach wildfly-ee and wildfly channels. Is that expected for an ee-build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In both cases, yes the limitations you point out are expected. This profile as is will not work for testing WFP or for testing wildfly-ee by itself.

https://issues.redhat.com/browse/WFLY-19268 will replace this, but it is out of scope for this task, which is really just about having an upstream variant of an urgent downstream change that tests a combination of these two FPs. Neither wildfly-ee-only testing nor wildfly-preview are relevant to the downstream change.

https://issues.redhat.com/browse/WFLY-19268 will take advantage of the greater flexibility we have in wildfly-maven-plugin 5, which is not used downstream.

yersan
yersan previously approved these changes Apr 24, 2024
@yersan yersan dismissed their stale review April 24, 2024 12:03

I want to do some local verifications

@bstansberry bstansberry added the 33.x WildFly 33 label Apr 24, 2024
@bstansberry bstansberry merged commit ea46d56 into wildfly:main Apr 28, 2024
15 checks passed
@bstansberry bstansberry deleted the WFLY-19267 branch April 28, 2024 19:25
@bstansberry
Copy link
Contributor Author

bstansberry commented Apr 28, 2024

Thanks @yersan. I'll be following up with another PR related to this that deals with bootable jar testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
33.x WildFly 33 deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
2 participants