WFLY-19349 Add missing protostream marshaller (and Immutability) for SessionMap.Mutex #17896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for analysis... |
github-actions
bot
added
the
deps-ok
|
Strange. org.glassfish:jakarta.faces:4.1.0 is missing from nexus (and maven central). Any ideas @jasondlee ? UPDATE: This is because the release ballot has not yet complete. I'll add a hold label until then. |
bstansberry
reviewed
Jun 13, 2024
| import java.util.concurrent.atomic.AtomicReference; | ||
|
|
||
| import jakarta.servlet.ServletContext; | ||
| import jakarta.servlet.http.HttpSession; |
There was a problem hiding this comment.
Since I'm on an import nazi kick....
jakarta isn't special like java and javax
jasondlee
approved these changes
Jun 13, 2024
|
Thanks @pferraro and @jasondlee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-19349
More information about the wildfly-bot[bot]