Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-1059] Add color-map attribute for pattern formatters #4869

Closed
wants to merge 4 commits into from

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Aug 1, 2013

So the subject doesn't say it all :)

First Commit (be8b31b)

The first commit is just to help tame the beast that is the logging subsystem configuration parser.

Second Commit (2c63cba)

The second commit just bumps the logging schema and model to 2.0.0.

Third Commit (f759306)

The third commit may or may not really be needed. At this point it's more of a place holder once 2.0 transformers are written.

Final Commit: (c803afa)

The final commit is the actual commit for the JIRA. This adds a new root resource called formatter. The only current formatter is the pattern-formatter, but there is a JIRA to allow for custom formatters which this change makes easier to implement.

I've also added a new attribute to most handlers called named-formatter. This attribute allows the new formatter resource to be defined for the handler. The original formatter attribute on the handler will continue to work in the same way it always has and will be the default when adding a handler.

There are currently no transformers for 2.0 -> 1.2, but there is WFLY-1807 to remedy that.

@wildfly-ci
Copy link

Build 313 is now running using a merge of c803afa925c4875b1a8d459c57dece48cff25736

private static final ModelNode UNDEFINED = new ModelNode();

static {
UNDEFINED.protect();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit iffy on it, but I was using it for undefining either the named-formatter if the formatter was explicitly set or the other way around. using `new ModelNode()`` might be a better solution though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or doing .clear() :)

@wildfly-ci
Copy link

Build 313 outcome was SUCCESS using a merge of c803afa925c4875b1a8d459c57dece48cff25736
Summary: Tests passed: 4004, ignored: 89 Build time: 1:26:16

@wildfly-ci
Copy link

Build 319 is now running using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98

@wildfly-ci
Copy link

Build 319 outcome was FAILURE using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98
Summary: Tests failed: 2 (2 new), passed: 4002, ignored: 89 Build time: 1:25:41

Failed tests

org.jboss.as.test.integration.ejb.timerservice.persistence.TimerServicePersistenceFirstTestCase.createAndCancelTimerService: java.lang.AssertionError
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.test.integration.ejb.timerservice.persistence.TimerServicePersistenceSecondTestCase.testTimerServiceNotCalled: java.lang.AssertionError
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

@jamezp
Copy link
Member Author

jamezp commented Aug 2, 2013

This failure is unrelated, retest this please

@wildfly-ci
Copy link

Build 327 is now running using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98

@wildfly-ci
Copy link

Build 327 outcome was FAILURE using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98
Summary: Tests passed: 3811, ignored: 86; exit code 1 (new) Build time: 1:50:46

@jamezp
Copy link
Member Author

jamezp commented Aug 4, 2013

retest this please

@wildfly-ci
Copy link

Build 330 is now running using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98

@wildfly-ci
Copy link

Build 330 outcome was SUCCESS using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98
Summary: Tests passed: 4002, ignored: 89 Build time: 1:26:11

@n1hility
Copy link
Member

n1hility commented Aug 8, 2013

nifty

@ctomc
Copy link
Contributor

ctomc commented Aug 9, 2013

this looks ok. @jamezp can you just rebase it to make sure, given some big changes ware merged recently.

@wildfly-ci
Copy link

Build 396 is now running using a merge of 20fee94

@jamezp
Copy link
Member Author

jamezp commented Aug 9, 2013

Rebased. Just a side note if anyone has an argument against not changing the default logging.properties and subsystem to use the new pattern-formatter, I have no strong opinion either way.

@wildfly-ci
Copy link

Build 396 outcome was SUCCESS using a merge of 20fee94
Summary: Tests passed: 4344, ignored: 82 Build time: 1:29:49

@n1hility
Copy link
Member

n1hility commented Aug 9, 2013

merged

@n1hility n1hility closed this Aug 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants