New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-1059] Add color-map attribute for pattern formatters #4869
Conversation
Build 313 is now running using a merge of c803afa925c4875b1a8d459c57dece48cff25736 |
private static final ModelNode UNDEFINED = new ModelNode(); | ||
|
||
static { | ||
UNDEFINED.protect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit iffy on it, but I was using it for undefining either the named-formatter
if the formatter
was explicitly set or the other way around. using `new ModelNode()`` might be a better solution though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or doing .clear() :)
Build 313 outcome was SUCCESS using a merge of c803afa925c4875b1a8d459c57dece48cff25736 |
Build 319 is now running using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98 |
Build 319 outcome was FAILURE using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98 Failed tests
|
This failure is unrelated, retest this please |
Build 327 is now running using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98 |
Build 327 outcome was FAILURE using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98 |
retest this please |
Build 330 is now running using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98 |
Build 330 outcome was SUCCESS using a merge of 5c4055eb2d7a26e0d5ece16c2772bfa87da38b98 |
nifty |
this looks ok. @jamezp can you just rebase it to make sure, given some big changes ware merged recently. |
…. Added a named-formatter option and a pattern-formatter to allow for shared formatters. Changed defaults to use the named formatters.
Rebased. Just a side note if anyone has an argument against not changing the default logging.properties and subsystem to use the new |
merged |
So the subject doesn't say it all :)
First Commit (be8b31b)
The first commit is just to help tame the beast that is the logging subsystem configuration parser.
Second Commit (2c63cba)
The second commit just bumps the logging schema and model to 2.0.0.
Third Commit (f759306)
The third commit may or may not really be needed. At this point it's more of a place holder once 2.0 transformers are written.
Final Commit: (c803afa)
The final commit is the actual commit for the JIRA. This adds a new root resource called
formatter
. The only current formatter is thepattern-formatter
, but there is a JIRA to allow for custom formatters which this change makes easier to implement.I've also added a new attribute to most handlers called
named-formatter
. This attribute allows the newformatter
resource to be defined for the handler. The originalformatter
attribute on the handler will continue to work in the same way it always has and will be the default when adding a handler.There are currently no transformers for 2.0 -> 1.2, but there is WFLY-1807 to remedy that.