Access log & default-web module support in undertow #4943

ctomc · 2013-08-20T14:32:47Z

No description provided.

wildfly-ci · 2013-08-20T14:36:37Z

Build 237 is now running using a merge of 5ae0f4026b3bedaf1c4459cedc5da15ffaa58463

stuartwdouglas · 2013-08-20T14:39:27Z

undertow/src/main/java/org/wildfly/extension/undertow/UndertowSubsystemParser_1_0.java

                                .addChild(
                                        builder(JspDefinition.INSTANCE)
                                                .setXmlElementName(Constants.JSP_CONFIG)
-                                                .addAttributes(


Don't do this, the attributes are listed explicitly to make forward compatibility easier. When we want to create a new schema version we can just make a copy of this file, however if just reference the attributes list directly this won't work, as items may be added or removed from the list.

Makes sense, I will revert this

wildfly-ci · 2013-08-20T15:48:51Z

Build 237 outcome was FAILURE using a merge of e396ffef248f22a9b927b62017bac704f9a48474
Summary: Tests failed: 9 (9 new), passed: 4391, ignored: 84 Build time: 1:12:14

Failed tests

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.setJvmRoute: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.getJvmRoute: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.getDefaultHost: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.getConnectors: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.findHost: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.getProxyConnector: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.getName: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.wildfly.mod_cluster.undertow.UndertowEngineTestCase.getHosts: java.lang.IllegalArgumentException: UT000008: Handler cannot be null
    at io.undertow.server.HttpHandlers.handlerNotNull(HttpHandlers.java:61)
    at io.undertow.server.handlers.NameVirtualHostHandler.addHost(NameVirtualHostHandler.java:75)

org.jboss.as.test.clustering.cluster.ejb3.security.FailoverWithSecurityTestCase(SYNC-tcp).testDomainSecurityAnnotation: javax.ejb.EJBException: java.io.IOException: Channel Channel ID d7795c63 (outbound) of Remoting connection 017599ab to null has been closed
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:236)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:181)

jaikiran · 2013-08-21T11:25:41Z

Those stacktraces look related to this PR change

wildfly-ci · 2013-08-21T12:23:31Z

Build 246 is now running using a merge of 3fe2a5888ac23dfdd367b9885d16d3a56016af9a

wildfly-ci · 2013-08-21T12:44:05Z

Build 247 is now running using a merge of cf30ad92995090233b7699f7a2cad69e82de8ef6

wildfly-ci · 2013-08-21T13:52:29Z

Build 247 outcome was SUCCESS using a merge of cf30ad92995090233b7699f7a2cad69e82de8ef6
Summary: Tests passed: 4400, ignored: 84 Build time: 1:8:24

kabir · 2013-08-22T10:08:31Z

build/src/main/resources/docs/schema/wildfly-undertow_1_0.xsd

@@ -169,6 +171,13 @@
        <xs:attribute name="name" use="required" type="xs:string"/>
        <xs:attribute name="handler" use="required" type="xs:string"/>
    </xs:complexType>
+    <xs:complexType name="accessLogType">
+        <xs:attribute name="pattern" use="required" type="xs:string"/>


This is nillable in the model, with a default of 'common'

kabir · 2013-08-22T10:58:47Z

retest this please

wildfly-ci · 2013-08-22T11:01:11Z

Build 265 is now running using a merge of 1349f0ba47d02b718edf5ff7f29e71f697c6a022

wildfly-ci · 2013-08-22T12:32:24Z

Build 265 outcome was FAILURE using a merge of 1349f0ba47d02b718edf5ff7f29e71f697c6a022
Summary: Tests failed: 2 (2 new), passed: 4411, ignored: 84 Build time: 1:31:12

Failed tests

org.jboss.as.test.smoke.webservices.WSTestCase.testManagementDescription: java.util.concurrent.TimeoutException
    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:258)
    at java.util.concurrent.FutureTask.get(FutureTask.java:119)

org.jboss.as.test.manualmode.ws.ReloadWSDLPublisherTestCase.testHelloStringAfterReload: java.lang.AssertionError: expected:<200> but was:<404>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

wildfly-ci · 2013-08-22T19:15:49Z

Build 269 is now running using a merge of 5600ecac85642a40d06443fb8e1f0bb527a8fc74

bstansberry · 2013-08-22T20:05:32Z

undertow/src/main/java/org/wildfly/extension/undertow/Host.java

    @Override
    public void start(StartContext context) throws StartException {
+        AccessLogService logService = accessLogService.getValue();


This will throw an ISE if there's no injection, and there won't be if there's no access log configured. InjectedValue.getOptionalValue() won't throw the ISE.

good catch, but to be fair ISE does not happen :) it just returns null.
probably bug in msc... i will fix it

Interesting. I thought it odd this wouldn't have failed a test somewhere, since I figured an access log probably wasn't configured everywhere.

wildfly-ci · 2013-08-22T20:27:34Z

Build 269 outcome was SUCCESS using a merge of 5600ecac85642a40d06443fb8e1f0bb527a8fc74
Summary: Tests passed: 4413, ignored: 84 Build time: 1:11:46

wildfly-ci · 2013-08-22T21:28:17Z

Build 271 is now running using a merge of ed0c9b1

wildfly-ci · 2013-08-22T22:38:39Z

Build 271 outcome was SUCCESS using a merge of ed0c9b1
Summary: Tests passed: 4413, ignored: 84 Build time: 1:10:23

bstansberry · 2013-08-22T22:40:10Z

Looks good.

stuartwdouglas · 2013-08-26T07:16:13Z

merged

stuartwdouglas reviewed Aug 20, 2013
View reviewed changes

ctomc mentioned this pull request Aug 21, 2013

Restore missing attribute from the JSP config #4946

Closed

kabir reviewed Aug 22, 2013
View reviewed changes

bstansberry reviewed Aug 22, 2013
View reviewed changes

ctomc and others added 5 commits August 22, 2013 23:23

WFLY-1721 - access log support

e70306a

WFLY-1894 Can't define default-web-module in undertow

aee519f

restore parser's enumerated attributes to help with versioned parsers

34e9ed5

Restore missing attribute from the JSP config

a76bcd1

WFLY-1930 - Upgrade XNIO to 3.1.0.CR6

ed0c9b1

stuartwdouglas closed this Aug 26, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Access log & default-web module support in undertow #4943

Access log & default-web module support in undertow #4943

ctomc commented Aug 20, 2013

wildfly-ci commented Aug 20, 2013

stuartwdouglas Aug 20, 2013

ctomc Aug 20, 2013

wildfly-ci commented Aug 20, 2013

jaikiran commented Aug 21, 2013

wildfly-ci commented Aug 21, 2013

wildfly-ci commented Aug 21, 2013

wildfly-ci commented Aug 21, 2013

kabir Aug 22, 2013

kabir commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

bstansberry Aug 22, 2013

ctomc Aug 22, 2013

bstansberry Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

bstansberry commented Aug 22, 2013

stuartwdouglas commented Aug 26, 2013

Access log & default-web module support in undertow #4943

Access log & default-web module support in undertow #4943

Conversation

ctomc commented Aug 20, 2013

wildfly-ci commented Aug 20, 2013

stuartwdouglas Aug 20, 2013

Choose a reason for hiding this comment

ctomc Aug 20, 2013

Choose a reason for hiding this comment

wildfly-ci commented Aug 20, 2013

Failed tests

jaikiran commented Aug 21, 2013

wildfly-ci commented Aug 21, 2013

wildfly-ci commented Aug 21, 2013

wildfly-ci commented Aug 21, 2013

kabir Aug 22, 2013

Choose a reason for hiding this comment

kabir commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

Failed tests

wildfly-ci commented Aug 22, 2013

bstansberry Aug 22, 2013

Choose a reason for hiding this comment

ctomc Aug 22, 2013

Choose a reason for hiding this comment

bstansberry Aug 22, 2013

Choose a reason for hiding this comment

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

bstansberry commented Aug 22, 2013

stuartwdouglas commented Aug 26, 2013