WFLY-1409 custom mail server should allow definition of independent prop... #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,7 +143,11 @@ private void setServerProps(final Properties props, final ServerConfig server, f | |||
| if (customProps != null && !customProps.isEmpty()) { | |||
| for (Map.Entry<String, String> prop : customProps.entrySet()) { | |||
| if (!props.contains(prop.getKey())) { | |||
| props.put(getPropKey(protocol, prop.getKey()), prop.getValue()); | |||
| if (prop.getKey().contains(".")){ | |||
There was a problem hiding this comment.
Sorry, I don't understand the change. I read the associated JIRA but couldn't co-relate this change to that. Do custom properties always have a "."? Or rather why are we checking the presence of "."?
There was a problem hiding this comment.
Quite simple, by default we build up prefix part of the mail configuration
so in case you are configuring pop3 server we are prefixing it with mail.pop3.
But that limits users to use only properties that start with predefined prefix (based on type).
So in case we now find property that has dots(".") in it we assume user wants to use whole property unmodified.
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...erties