Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-1988 : SaslException at startup in domain mode using JAAS for ManagementRealm #5046

Closed
wants to merge 1 commit into from
Closed

WFLY-1988 : SaslException at startup in domain mode using JAAS for ManagementRealm #5046

wants to merge 1 commit into from

Conversation

ehsavoie
Copy link
Contributor

The issue was reopened because there is also a problem with non ASCII chars in authkey which was 'unmasked' by the previous fix
Thus now the authKey is generated using only ASCII chars.
https://issues.jboss.org/browse/WFLY-1988

@wildfly-ci
Copy link

Build 526 is now running using a merge of ed92d07f6b6b75ced2f2038b97022595536822ef

@wildfly-ci
Copy link

Build 526 outcome was SUCCESS using a merge of ed92d07f6b6b75ced2f2038b97022595536822ef
Summary: Tests passed: 4773, ignored: 88 Build time: 1:25:08

@n1hility
Copy link
Member

Hmm a glance plain sasl auth looks like it should support the full UTF8 character set minus nulls. Is there a reason you are capping the range to be as small?

@ehsavoie
Copy link
Contributor Author

I have some errors (3 in 1000 restarts) witch makes this difficult to reproduce so I might have err on the side of caution.
I'm trying to get something reproductible so we might wait before merging it in the meantime.

@ehsavoie
WFLY-1988 : Instead of testing password equality on String, using byt…
2b26a19 
…e array equality as we might have undefined chars from the random bytes in authKey.

Conflicts:
	host-controller/src/main/java/org/jboss/as/host/controller/ServerInventoryImpl.java
@ehsavoie
Copy link
Contributor Author

The problem was in String equality for passwords that doesn't function properly with undefined UTF-8 chars. Using byte array equality does the trick (recreating String form the bytes works also).

@wildfly-ci
Copy link

Build 574 is now running using a merge of 2b26a19

@wildfly-ci
Copy link

Build 574 outcome was SUCCESS using a merge of 2b26a19
Summary: Tests passed: 4788, ignored: 88 Build time: 1:35:06

@bstansberry
Copy link
Contributor

Merged.

@ehsavoie ehsavoie deleted the WFLY-1988 branch March 28, 2014 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ehsavoie @wildfly-ci @n1hility @bstansberry