[WFLY-2167] Set resolve-path operation to be a READ_ONLY and RUNTIME_ONLY operation #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,8 @@ | |||
| private static final SimpleOperationDefinition DEFAULT_OPERATION_DEFINITION = new SimpleOperationDefinitionBuilder(OPERATION_NAME, new ResolvePathResourceDescriptionResolver(OPERATION_NAME)) | |||
| .addParameter(RELATIVE_TO_ONLY) | |||
| .setReplyType(ModelType.STRING) | |||
| .setReadOnly() | |||
| .setRuntimeOnly() | |||
There was a problem hiding this comment.
It's not really runtime-only. Is adding that necessary to get the metadata to appear in read-resource-description?
There was a problem hiding this comment.
Yes, it has to be RUNTIME_ONLY if it's a domain server, https://github.com/wildfly/wildfly/blob/master/controller/src/main/java/org/jboss/as/controller/operations/global/ReadOperationDescriptionHandler.java#L86.
There was a problem hiding this comment.
OK, thanks. I'll look into correcting that. I might even have a JIRA open to do so somewhere.
n1hility
added a commit
that referenced
this pull request
Sep 30, 2013
[WFLY-2167] Set resolve-path operation to be a READ_ONLY and RUNTIME_ONLY operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
READ_ONLYandRUNTIME_ONLYflags on theresolve-pathoperation. This is needed in domain mode for the describe operation to work correct. Also CLI tab complete.